Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search box out of screen #2650

Merged
merged 4 commits into from Mar 7, 2021
Merged

Fix search box out of screen #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43e3397
Programatically set search results max height
askvortsov1 Mar 2, 2021
1a631c2
Format
askvortsov1 Mar 2, 2021
f5429b9
Move max height calculation to oncreate, add comment
askvortsov1 Mar 5, 2021
c0bb3dc
Move maxHeight calculation to onupdate
askvortsov1 Mar 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions js/src/forum/components/Search.js
View file
Open in desktop
Expand Up @@ -113,6 +113,13 @@ export default class Search extends Component {
onupdate() {
// Highlight the item that is currently selected.
this.setIndex(this.getCurrentNumericIndex());

// Since extensions might add elements above the search box on mobile,
// we need to calculate and set the max height dynamically.
const resultsElementMargin = 14;
const maxHeight =
window.innerHeight - this.element.querySelector('.Search-input>.FormControl').getBoundingClientRect().bottom - resultsElementMargin;
this.element.querySelector('.Search-results').style['max-height'] = `${maxHeight}px`;
}

oncreate(vnode) {
Expand Down
1 change: 0 additions & 1 deletion less/common/Search.less
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@
}
}
.Search-results {
max-height: 70vh;
overflow: auto;
left: auto;
right: 0;
Expand Down