Posts are no longer deleted when users are deleted, so the error mess… #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age should reflect that.
|
I don't think bringing special attention to a users posts is necessary. I am saying this because extensions have constraints on the user as well. Maybe we should completely drop that second sentence completely? |
|
IMO it should be clear that deleting user account will not remove posts from forum. |
|
I changed it to that because this is the language that deleting groups prints out. If we're getting rid of that, should we change that as well? I also agree that we should clarify, considering it might not be immediately obvious. If extensions have an issue with it, they can override the displayed string? |
askvortsov1
added a commit
that referenced
this pull request
Mar 11, 2022
Posts are no longer deleted when users are deleted, so the message should reflect that. (#157)
askvortsov1
added a commit
that referenced
this pull request
May 10, 2022
Posts are no longer deleted when users are deleted, so the message should reflect that. (#157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…age should reflect that.
Fixes flarum/framework#1928 by updating the warning message when deleting a user.