Added listener to follow after a reply #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added listener to add setting to a user
| { | ||
| $actor = $event->actor; | ||
|
|
||
| if ($actor && $actor->exists && $actor->getPreference('followAfterReply')) { |
There was a problem hiding this comment.
Expected 1 newline after opening brace; 2 found
|
Referencing: flarum/lang-english#57 |
| @@ -17,8 +19,10 @@ app.initializers.add('subscriptions', function() { | |||
| addSubscriptionBadge(); | |||
| addSubscriptionControls(); | |||
| addSubscriptionFilter(); | |||
| console.log('subscription'); | |||
Moved to english keys inside the subscription package
|
As mentioned in the flarum/framework#310 i updated this to include the changes. But currently i added a toggle button for this setting. I don't know what the best option is to toggle this. Or how to fix the ordering. When i use the example code of @tobscure the buttons are nested inside the div of the Notification grid. Which is not ideal. |
|
Thanks @petermein! I fixed it up and squash-merged it in. 98276f9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added listener to add setting to a user