Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding suspension with date in the past #40

Closed
wants to merge 1 commit into from

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Oct 6, 2021

Fixes issue identified in QA

Changes proposed in this pull request:

Don't allow a date in the past to be used as a new suspension end date. Previously, if this was done, user would see a suspension notification without actually being suspended.

Reviewers should focus on:

Does this change any existing behaviour?

Not tested locally. Will do so after some more QA checking.

Confirmed

  • Backend changes: tests are green (run composer test).

@davwheat davwheat added the bug label Oct 6, 2021
@davwheat davwheat self-assigned this Oct 6, 2021
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we include automated tests for this? That would also add some coverage to general suspend functionality, and set up infra for future testing expansion.

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Willing to approve this without tests, but why "today" and not "now"?

@askvortsov1
Copy link
Sponsor Member

Hello, thank you for your pull request! In order to speed up future development, keep all work in one place, and take advantage of CI tools that can help us avoid breaking changes, we have moved all Flarum code to a single monorepo at flarum/framework. You can read more about this process in our dev diary. Unfortunately, pull requests can't be carried over to the monorepo, so we have to close all open pull requests. If this pull request is still relevant, please feel free to reopen it over on the monorepo. We apologize for the inconvenience, and hope you will consider contributing to Flarum again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants