Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscussionWasViewed properties should be public #7

Closed
simon1222 opened this issue Jan 25, 2021 · 1 comment · Fixed by #10
Closed

DiscussionWasViewed properties should be public #7

simon1222 opened this issue Jan 25, 2021 · 1 comment · Fixed by #10

Comments

@simon1222
Copy link

DiscussionWasViewed has private properties, so when I set listener on this event, I don't have any access to values.
@imorland
Copy link
Contributor

imorland commented Mar 8, 2021

Sorry for the delay here. I'll adjust this oversight in the upcoming beta 16 release. Thanks!

imorland added a commit that referenced this issue Mar 8, 2021
@imorland
Make event properties public #7
d8f4814
@imorland imorland linked a pull request Mar 8, 2021 that will close this issue
Beta16 #8
Closed
imorland added a commit that referenced this issue Mar 12, 2021
@imorland
Make event props public #7
0e8ca12
@imorland imorland removed a link to a pull request Mar 12, 2021
Beta16 #8
Closed
@imorland imorland linked a pull request Mar 12, 2021 that will close this issue
Make event properties public #10
Merged
imorland added a commit that referenced this issue Mar 12, 2021
@imorland
Make event properties public (#10)
89b3f0b 
* Make event props public #7

* Update lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make event properties public flarumite/simple-discussion-views
2 participants
@imorland @simon1222