Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require relay pubkey #143

Merged
merged 1 commit into from
Jun 10, 2022
Merged

require relay pubkey #143

merged 1 commit into from
Jun 10, 2022

Conversation

metachris
Copy link
Collaborator

@metachris metachris commented Jun 9, 2022

require the relay pubkey, error if not given

related: #138

Copy link
Contributor

@0xpanoramix 0xpanoramix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@metachris metachris changed the base branch from main to develop June 9, 2022 17:53
@metachris metachris mentioned this pull request Jun 9, 2022
7 tasks
@metachris metachris merged commit 54eeaa2 into develop Jun 10, 2022
@metachris metachris deleted the require-relay-pubkey branch June 10, 2022 11:31
metachris added a commit that referenced this pull request Jun 10, 2022
metachris added a commit that referenced this pull request Jun 14, 2022
* Add signature verifications (#138)

* Add signature verification for getHeader response

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Remove typo

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Add signature verification for registerValidator request

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Update mergemock integration tests

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Fix typo in flag

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Add error logging

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Add signature verification tests

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Require the relay pubkey (#143)

* mev-boost cli flags for setting genesis fork version, computing correct domain (#148)

* better errors on failed signature validation (#151)

Co-authored-by: Luca G.F <luca.georges-francois@epitech.eu>
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
* Add signature verifications (flashbots#138)

* Add signature verification for getHeader response

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Remove typo

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Add signature verification for registerValidator request

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Update mergemock integration tests

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Fix typo in flag

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Add error logging

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Add signature verification tests

Signed-off-by: Luca Georges Francois <luca.georges-francois@epitech.eu>

* Require the relay pubkey (flashbots#143)

* mev-boost cli flags for setting genesis fork version, computing correct domain (flashbots#148)

* better errors on failed signature validation (flashbots#151)

Co-authored-by: Luca G.F <luca.georges-francois@epitech.eu>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants