remove manual gzipping of request, as it's done automatically! #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #365 and replaces #382
http.Request automatically adds
Accept-Encoding: gzip
header and transparently decompresses the response. You can see this working in the test in this PR. Also see https://pkg.go.dev/net/http#Response.UncompressedBut when the header is set manually, then it won't decode the response automatically, which is what we're seeing in #382
In fact, gzip was already support since the very beginning of mev-boost. :)
✅ I have run these commands
make lint
make test-race
go mod tidy