feat: Add a lower block bound to check_provider_factory_health #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results for
|
| Date (UTC) | 2024-07-05T07:58:16+00:00 |
| Commit | 9c514d75acd124ac316fa18d3f42df47e08ff2b7 |
| Base SHA | a25f33b44d80a9ea12ac5ea2e68e54a89ce092a8 |
Significant changes
None
dvush
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
If the current block number is less than 256, the
check_provider_factory_healthwill overflow and check for the block of the max uint which will not exists. This can happen in devnets with a few blocks.✅ I have completed the following steps:
make lintmake test