Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete unused features of alloy-chains #66

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

zzzzzzch
Copy link
Contributor

@zzzzzzch zzzzzzch commented Jul 16, 2024

📝 Summary

hi, this PR


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copy link

github-actions bot commented Jul 16, 2024

Benchmark results for 9d5bc2c

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/9d5bc2c-bb39c03/report/index.html

Date (UTC) 2024-07-30T17:32:59+00:00
Commit 9d5bc2ca35a1f986f2ccb7e9d419297e30588cca
Base SHA bb39c03460c0e379b887ddd31ba97f0f84cee52e

Significant changes

None

@zzzzzzch
Copy link
Contributor Author

I also noticed that some config entries for dummy-builder are hardcoded instead of being read from the config file. Is this intentional, or would it be better to change it to read from the config file? If it's the latter, I'll try to update this code

@ferranbt
Copy link
Contributor

I also noticed that some config entries for dummy-builder are hardcoded instead of being read from the config file. Is this intentional, or would it be better to change it to read from the config file? If it's the latter, I'll try to update this code

Hi, can you point me which entries?

@ferranbt ferranbt self-requested a review July 18, 2024 11:05
@zzzzzzch
Copy link
Contributor Author

I also noticed that some config entries for dummy-builder are hardcoded instead of being read from the config file. Is this intentional, or would it be better to change it to read from the config file? If it's the latter, I'll try to update this code

Hi, can you point me which entries?

hi, the dummy-builder does not parse params from Cli, so param such as reth_datadir are hardcoded with DEFAULT_RETH_DB_PATH (which is /mnt/data/reth and causes an error on my machine because my reth db is not in this directory)

@zzzzzzch zzzzzzch force-pushed the develop branch 2 times, most recently from def332c to 67ba983 Compare July 19, 2024 15:56
@zzzzzzch zzzzzzch changed the title fix: delete unused features of alloy-chains fix: delete unused features of alloy-chains and update version Jul 19, 2024
@zzzzzzch zzzzzzch requested a review from ferranbt July 19, 2024 15:58
@metachris
Copy link
Contributor

metachris commented Jul 25, 2024

@zzzzzzch could you please fix the linter issues? 🙏

@zzzzzzch zzzzzzch changed the title fix: delete unused features of alloy-chains and update version fix: delete unused features of alloy-chains and fix lint errors Jul 27, 2024
@zzzzzzch
Copy link
Contributor Author

@zzzzzzch could you please fix the linter issues? 🙏

hi @metachris, the linter issues are fixed. Please review😀

@dvush
Copy link
Contributor

dvush commented Jul 30, 2024

@zzzzzzch can you update your branch? I did this on the branch pr_66_2 in this repo but I can't push here.

@zzzzzzch
Copy link
Contributor Author

@zzzzzzch can you update your branch? I did this on the branch pr_66_2 in this repo but I can't push here.

@dvush great. I have rebased my branch

@zzzzzzch zzzzzzch changed the title fix: delete unused features of alloy-chains and fix lint errors fix: delete unused features of alloy-chains Jul 30, 2024
@dvush dvush merged commit 2a6809a into flashbots:develop Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused manifest key alloy-chains.feature
4 participants