Various changes #34
Closed
Various changes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the write speed would be set by `spispeed` argument. In this commit, read speed will also be set by that. Tested on Widora NEO with mainline OpenWrt (Linux 4.9) and software emulated SPI (spi-gpio). No errors but SPI remains on about 1.5MHz. This is due to the performance limitation of spi-gpio driver in the linux kernel. The hardware on this board is too weak to run with a higher SPI clock speed (CPU is MTK's MT7688, single MIPS24kc core @ 580MHz). As a result, this patch should be tested by others again if you have a more powerful device. Change-Id: If834ab4a94f5f591137e3dede84bbb9530b65ad0 Signed-off-by: Jackson Ming Hu <huming2207@gmail.com>
Tested with W25Q256JV and W25Q256FV chips, no errors. Change-Id: Ic8b64bd0841c93db544b9af15f824139a7e45cba Signed-off-by: Jackson Ming Hu <huming2207@gmail.com>
1. Try chip erase first before other erase methods 2. Decrease BUSY waiting time This patch may siginificantly improve erase performance, especially on some chips which have built-in chip-erase support (e.g. W25Q128, 16MB, ~120s -> ~55s). Change-Id: I9e6628931205b6d1de4d96fa346e4cdf07f65845 Signed-off-by: Jackson Ming Hu <huming2207@gmail.com>
Some Winbond W25Q flash chips (larger than 128Mbit) support 4-byte addressing mode. Those chips also allows setting to 4-byte addressing as default when powering up. But some devices may not support 4-byte addressing mode in their bootloaders/kernels. As a result, this update allows user to read/enable/disable this feature by setting the ADP bit in the 3rd status register inside the flash chip. Ref: https://www.winbond.com/resource-files/w25q256fv_revg1_120214_qpi_website_rev_g.pdf Page 12, 18, 33-35 Change-Id: I54cd59e0a3cc1f08b2c03db01d73bc0a0170b192 Signed-off-by: Jackson Ming Hu <huming2207@gmail.com>
Previously if user picks a image file which are smaller than the chip size, this program will throws an "Image size mismatch" error. But it should be allowed anyway, just like those commercial SPI programmer products did. Change-Id: I1dc1922d4b8ee07ebef58c6196a5576ce6bd99f7 Signed-off-by: Jackson Ming Hu <huming2207@gmail.com>
|
@huming2207 Sorry, but KB9012 support patches have been already merged with the flashrom's master branch at 12 February 2018. Please check what commits of your pull request are still important, and rebase them on top of the flashrom's master branch. Ideally that should be done at gerrit - https://review.coreboot.org/q/project:flashrom+status:open |
|
@mikebdp2 Hello Mike, Sorry for that I forgot this pull request and I cherry-picked that commit into my repo's master branch. I will consider removing it later. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Here are some changes I've made in my internship project previously, including:
linux_spimaximum write speed.I'm not sure if I should put several commits in one PR, but I have no idea how to separate them in one branch. If you are not happy about that, I'll create more than one branches and put each of the commit in the branch separately.
Regards,
Jackson