kola/test: disable tests that won't work with docker 20.10 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
pothos
requested changes
Aug 6, 2021
jepio
force-pushed
the
jepio/disable-legacy-docker-tests-on-alpha
branch
2 times, most recently
from
aff2741
to
3ff956e
Compare
These tests are 'docker.oldclient' and 'google.kubernetes.basic.docker.*'.
'docker.oldclient' tries to run docker cli 1.9 against daemon in the
image, and fails with:
--- FAIL: docker.oldclient (29.22s)
cluster.go:117: Error response from daemon: 400 Bad Request: malformed Host header
cluster.go:130: "/home/core/docker-1.9.1 run echo echo 'IT WORKED'" failed: output , status Process exited with status 1
This is related to moby/moby#39076, merged into
20.10 which removed some backwards compatibility.
The 'google.kubernetes.basic.docker.*' tests fails with the following
message in journal:
Jul 15 14:17:42.446942 kubelet[4663]: F0715 14:17:42.446505 4663 server.go:274] failed to run Kubelet: misconfiguration: kubelet cgroup driver: "cgroupfs" is different from docker cgroup driver: "systemd"
Kubernetes release 1.19 is the first one that properly supports the unified cgroup hierarchy.
We also have other tests that test that kubernetes works (kubeadm) so we
can disable the legacy ones.
The old tests should be removed once the docker 20.10 upgrade has
propagated to all channels.
See also flatcar-archive/coreos-overlay#931
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
jepio/disable-legacy-docker-tests-on-alpha
branch
from
3ff956e
to
6d21aef
Compare
pothos
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable old tests for alpha channel
docker 1.9 and kubernetes <1.19 are not compatible with docker 20 that we are rolling into alpha. These tests need to be excluded, to be removed later.
How to use
Fetch the image from http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3035/ and run test (
kola run)Testing done
kola runSee also flatcar-archive/coreos-overlay#931