Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plume: update GCS URL to bincache URL #371

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 9, 2022

  • plume: remove BasePrivateURL
    it's no more used.

  • plume/release: update GCS URL to bincache URL


I was expecting more complexity to update this URL but it seems that storage is able to understand both type of URL, it converts GCS URL to plain HTTP url:
https://github.com/flatcar-linux/mantle/blob/fb7bbf6e2c863c0bcfb9dcba4c090e45eb8c4742/cmd/plume/containerlinux.go#L326-L328

Related issue: flatcar/Flatcar#838

it's no more used.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@pothos
Copy link
Member

pothos commented Sep 9, 2022

Thanks, one last missing piece is to split the ami txt/json file creation out of awsUploadAmiLists in a separate function which we then always call. There we could store them as local files. (awsUploadAmiLists would still be skipped when no GCS creds are given; the signing and copy to bincache is better done by the ci-automation bash code).

@tormath1 tormath1 marked this pull request as ready for review September 12, 2022 12:32
@tormath1 tormath1 merged commit 849541e into flatcar-master Sep 12, 2022
@tormath1 tormath1 deleted the tormath1/gcs branch September 12, 2022 12:53
@pothos
Copy link
Member

pothos commented Sep 12, 2022

Thanks, one last missing piece is to split the ami txt/json file creation out of awsUploadAmiLists in a separate function which we then always call. There we could store them as local files. (awsUploadAmiLists would still be skipped when no GCS creds are given; the signing and copy to bincache is better done by the ci-automation bash code).

Done in #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants