kola/tests: Replace nmap's ncat with openbsd ncat #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
krnowak
force-pushed
the
krnowak/openbsd-netcat
branch
3 times, most recently
from
3dab3fd
to
8fb4cd1
Compare
krnowak
changed the title
krnowak
force-pushed
the
krnowak/openbsd-netcat
branch
from
8fb4cd1
to
979c8a2
Compare
|
Ready for review. The changes in crio and podman tests are untested - we are not running those on Flatcar. |
|
Just occurred to me that the docker network test will need a split - old version with nmap ncat, new version with openbsd nc. |
krnowak
force-pushed
the
krnowak/openbsd-netcat
branch
from
979c8a2
to
755b614
Compare
|
CI on older versions (to test if nmap ncat docker.network still works):
Also rekicked test-dispatcher jobs in CI for the new versions (at http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/4414/cldsv/) |
|
CI passed. |
|
Will drop the |
chewi
approved these changes
Aug 9, 2024
ader1990
approved these changes
Aug 9, 2024
Nmap's ncat will be replaced in newer versions with OpenBSD nc. But keep the old test intact, as the older channels still have nmap's ncat. The CRIO and podman are untested - they do not run on Flatcar.
krnowak
force-pushed
the
krnowak/openbsd-netcat
branch
from
755b614
to
a602f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD netcat has no long flags and has no idle timeout flag, so these need to be replaced with short flags and using a timeout utility, respectively.