add postinstall hook to stay on cgroupv1 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a coming release we will enable cgroupv2 by default in systemd. We are trying to not break existing kubernetes deployments, which can't handle this kind of change without intervention, so the postinstall hook will add the 'systemd.cgroup_unified_hierarchy' to the kernel command line to keep older nodes on cgroupv1. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Merged
7 tasks
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 2, 2021
This pulls in flatcar/update_engine#13 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
pothos
reviewed
Aug 2, 2021
pothos
reviewed
Aug 2, 2021
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Tell users to remove if they don't need it. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
The cgroup migration is not needed on nightly builds because they are should test the latest code and are normally not updated by update_engine anyway. Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 6, 2021
This pulls in flatcar/update_engine#13 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
pothos
approved these changes
Aug 6, 2021
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 6, 2021
This pulls in flatcar/update_engine#13 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
We are changing the 'SystemdCgroup' setting of containerd to true in the config.toml file, but have kept the previous configuration with the name config-cgroupfs.toml. When we upgrade, we can drop a systemd unit that will move to the frozen configuration. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
…ybrid hierarchy Seems that systemd.unified_cgroup_hierarchy alone is not enough to avoid cgroup2, one also needs to pass another parameter to avoid the hybrid hierarchy. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
@pothos could you take a look at the last two commits:
|
pothos
reviewed
Aug 10, 2021
pothos
reviewed
Aug 10, 2021
pothos
approved these changes
Aug 11, 2021
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 12, 2021
This pulls in flatcar/update_engine#13 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
This pulls in flatcar/update_engine#13 Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add postinstall hook to stay on cgroupv1
Changing cgroup setting on a provisioned system is guaranteed to cause trouble with kuberntes clusters. In order to not disturb operations during a routing update, a postinstall hook is added that modifies the OEM grub.cfg to keep the system on cgroupv1. This will allow us to migrate the alpha channel to cgroupv2.
Part of flatcar-archive/coreos-overlay#931
How to use
Boot alpha 2942.0.0.
Use flatcar/Flatcar#70 (comment) to update to a development snapshot containing this change.