-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode Flatcar containerd exec command #12177
Hardcode Flatcar containerd exec command #12177
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.21 Automated cherry pick of #12177: Hardcode Flatcar containerd exec command
Hi, just wanted add an observation: the two referenced Flatcar PRs didn't change the containerd command, the previous override method was not successful ( |
Thanks for the explanation @jepio. Was a bit harder these days to keep track with any Flatcar related issues as the periodic tests keep failing since kOps switched to IMDSv2 by default for AWS. Not sure if anyone is looking into that, but seems like a pretty simple ignition issue (see: flatcar/ignition#32). |
The containerd command used in kubernetes#12177 is a modification from the torcx containerd unit. However, how torcx starts containerd is a implementation detail and it's better to not hardcode torcx in case it isn't used anymore. Change the ExecStard command to use /usr/bin/containerd directly, making it simpler and more future-proof.
The containerd command used in kubernetes#12177 is a modification from the torcx containerd unit. However, how torcx starts containerd is a implementation detail and it's better to not hardcode torcx in case it isn't used anymore. Change the ExecStard command to use /usr/bin/containerd directly, making it simpler and more future-proof.
The containerd command used in kubernetes#12177 is a modification from the torcx containerd unit. However, how torcx starts containerd is a implementation detail and it's better to not hardcode torcx in case it isn't used anymore. Change the ExecStard command to use /usr/bin/containerd directly, making it simpler and more future-proof.
As part of flatcar-archive/coreos-overlay#931 and flatcar/update_engine#13, Flatcar decided to change the containerd exec command and not allow an easy override of the config file.
https://kinvolk.io/docs/flatcar-container-linux/latest/container-runtimes/customizing-docker/#use-a-custom-containerd-configuration
/cc @rifelpet