Allow finish-args-unnecessary-xdg-data-access for jdMinecraftLauncher #86
Conversation
| @@ -817,7 +817,8 @@ | |||
| "appid-uses-code-hosting-domain": "app-id predates this linter rule" | |||
| }, | |||
| "com.gitlab.JakobDev.jdMinecraftLauncher": { | |||
| "appid-uses-code-hosting-domain": "app-id predates this linter rule" | |||
| "appid-uses-code-hosting-domain": "app-id predates this linter rule", | |||
| "finish-args-unnecessary-xdg-data-access": "jdMinecraftLauncher creates .desktop files in share/applications" | |||
There was a problem hiding this comment.
Pretty sure this was added after jdMinecraftLauncher has been published to Flathub. It should be switched to use the dynamic portal that e.g. Epiphany uses to install PWAs like native apps.
There was a problem hiding this comment.
Pretty sure this was added after jdMinecraftLauncher has been published to Flathub.
That's right. the feature to create shortcuts have been added a few months after to the Program.
It should be switched to use the dynamic portal that e.g. Epiphany uses to install PWAs like native apps.
If you are talking about the DynamicLauncher Portal, tthere are plenty of reasons to not use it.
-
It's pretty new, so not all Distros support it.
-
It doesn't support creating files on the Desktop, so I have to manage 2 different functions: One for the Portal and one for normally writing files on the Desktop.
-
It doesn't work outside the sandbox, so I still have to manage 2 different functions: One from inside the Flatpak and one for outside.
-
Even if all the problems above solved, I can't implement it. There is a Bug in pyQt6 that prevents this. I reported a Bug, but the answer was, that it could not been reproduced (even if another User could reproduce it), so this Bug is still not fixed today.
jdMinecraftLauncher needs this to create menu shortcuts in share/applications.