Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow finish-args-unnecessary-xdg-data-access for jdMinecraftLauncher #86

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Allow finish-args-unnecessary-xdg-data-access for jdMinecraftLauncher #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion flatpak_builder_lint/staticfiles/exceptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,8 @@
"appid-uses-code-hosting-domain": "app-id predates this linter rule"
},
"com.gitlab.JakobDev.jdMinecraftLauncher": {
"appid-uses-code-hosting-domain": "app-id predates this linter rule"
"appid-uses-code-hosting-domain": "app-id predates this linter rule",
"finish-args-unnecessary-xdg-data-access": "jdMinecraftLauncher creates .desktop files in share/applications"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this was added after jdMinecraftLauncher has been published to Flathub. It should be switched to use the dynamic portal that e.g. Epiphany uses to install PWAs like native apps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this was added after jdMinecraftLauncher has been published to Flathub.

That's right. the feature to create shortcuts have been added a few months after to the Program.

It should be switched to use the dynamic portal that e.g. Epiphany uses to install PWAs like native apps.

If you are talking about the DynamicLauncher Portal, tthere are plenty of reasons to not use it.

  1. It's pretty new, so not all Distros support it.

  2. It doesn't support creating files on the Desktop, so I have to manage 2 different functions: One for the Portal and one for normally writing files on the Desktop.

  3. It doesn't work outside the sandbox, so I still have to manage 2 different functions: One from inside the Flatpak and one for outside.

  4. Even if all the problems above solved, I can't implement it. There is a Bug in pyQt6 that prevents this. I reported a Bug, but the answer was, that it could not been reproduced (even if another User could reproduce it), so this Bug is still not fixed today.

},
"com.gitlab.jakobdev.jdnbtexplorer": {
"appid-uses-code-hosting-domain": "app-id predates this linter rule"
Expand Down