-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qwebengine fix #5
Conversation
in order to keep the git diffs humanly readable...
changing the format of the manifest is the best way to obfuscate the changes. Is this really necessary? |
also "python3-modules.json" was likely autogenerated by the flatpak-builder-tools, making the use of the tool impossible down the way, making the maintainer life harder. |
This is a complete rewrite, nothing to be obfuscated here. YML is the easier format to work with, that is why I use it. regenerating the autogenerated file is not a problem |
the autogenerated module is back to json now |
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Co-authored-by: Hubert Figuière <hub@figuiere.net>
I guess I need to convert this to an actual PR in order to get the flathubbot building? |
no, it should have been detected bot, build |
Queued test build for ch.theologeek.Manuskript. |
Started test build 84573 |
Build 84573 failed |
Okay, so I tested the build and it seems to work as intended. The PDF preview finally works which is awesome. The installation gets cleaned up a bit now. The only downside would be that the build for aarch64 fails. The log states that it mostly fails because of the missing type |
Signed-off-by: TheJackiMonster <thejackimonster@gmail.com>
Started test build 84771 |
Build 84771 failed |
Worst case would be to disable the pdf preview for aarch64. I wonder why the build failed this time though, it looks like some network problem, since it did not even start to build. |
Queued test build for ch.theologeek.Manuskript. |
Started test build 84782 |
looks like the same error is happening again :( |
You need to disable desktopGL on aarch64. Because the SDK is built without it on aarch64. It worked with the previous manifest though. |
Build 84782 failed |
attempt to fix build issues on aarch64
Queued test build for ch.theologeek.Manuskript. |
1 similar comment
Queued test build for ch.theologeek.Manuskript. |
Started test build 84809 |
Build 84809 failed |
I don't quite understand what the error is, but it is happening during the build of QtGui, so I am not sure if this is even related to QtOpenGL |
Started test build 85251 |
Build 85251 successful
|
@TheJackiMonster alright so building all PyQt modules (like the old manifest did) seems to solve the build issues on aarch64. It does increase the size of the image since it includes modules that are not needed. |
Started test build 85262 |
Queued test build for ch.theologeek.Manuskript. |
1 similar comment
Queued test build for ch.theologeek.Manuskript. |
Queued test build for ch.theologeek.Manuskript. |
1 similar comment
Queued test build for ch.theologeek.Manuskript. |
Build 85262 failed |
Started test build 85268 |
Build 85268 successful
|
nice it seems to work! Please review @TheJackiMonster :) |
Signed-off-by: TheJackiMonster <thejackimonster@gmail.com>
Started test build 85274 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will probably add the import into the startup script from the repository or maybe even into the script using the QtWebWidgets. Then I should replace the manuskript.py
with the usual startup script from repository again.
But the import in the added manuskript.py
seems to be necessary for the PDF preview to work. For now this PR seems to be a good solution. I will make the required adjustments with the next release but these changes should improve the current flatpak already for version 0.13.1 a lot. ^^
Thank you very much.
Build 85274 successful
|
As discussed on Reddit, this is a complete rewrite from scratch of all manifests.
It uses the latest version of PyQt5 and fixes the QWebengine problem.
This is a draft for now so I can do some testing with the version build by the flathub-bot.