Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the flatpak #1029

Closed
TheJackiMonster opened this issue Apr 7, 2022 · 1 comment
Closed

Cleaning up the flatpak #1029

TheJackiMonster opened this issue Apr 7, 2022 · 1 comment
Assignees
Milestone

Comments

@TheJackiMonster
Copy link
Collaborator

As mentioned in the PR from the flatpak here. The statement import PyQt5.QtWebEngineWidgets as webengine seens to be necessary in the code for the PDF preview to work in the flatpak. I'm not sure why this doesn't seem to be an issue in any other version but I assume it would be best to load this dependency either in our usual startup script at bin/manuskript before calling main() or adding it into the file responsible for the PDF preview.

Another aspect I promised to do for the next release is getting rid of the .appdata.xml-file and the .desktop-file in the flatpak repository. Manuskript should only have a single .desktop-file and a single .appdata.xml-file in its repository after cleaning it up and the flatpak will reuse them instead of maintaining own files separate.

@TheJackiMonster
Copy link
Collaborator Author

I've already done the necessary part of this in this repository. The commit for the flatpak is ready to be published. Therefore I will close this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant