Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission issue with attachments? #14

Closed
hpk42 opened this issue Mar 31, 2019 · 5 comments · Fixed by #15
Closed

Permission issue with attachments? #14

hpk42 opened this issue Mar 31, 2019 · 5 comments · Fixed by #15

Comments

@hpk42
Copy link

hpk42 commented Mar 31, 2019

Seems some folks have issues with not being able to attach files from the host system.

https://twitter.com/mjjzf/status/1107620941515902977

@muelli
Copy link
Collaborator

muelli commented Apr 1, 2019

yes. That's another bucket of sand that Electron apps throw into your apps.
It doesn't use a native file picker widget.

We can relax the security of the sandbox and allow access to files. Telegram, for example, allows xdg-download. Signal allows the home directory.
We could do something like that or give full (read) access to the host, if you want.

There seems to be a patch here and I think it'd be good to address this issue by getting that patch ready rather than working around the symptoms by relaxing the sandbox.

@muelli
Copy link
Collaborator

muelli commented Apr 1, 2019

FTR: You can change the permissions yourself, if you feel so inclined, with something like
flatpak --user override --filesystem=home:rw chat.delta.desktop

@flub
Copy link
Collaborator

flub commented Apr 26, 2019

I'd vote for doing the same as signal here. Does dc-desktop also need to be able to write files? Maybe something like --filesystem=home:ro --filesystem=xdg-download:rw would be sane?

@Simon-Laux
Copy link
Collaborator

Does dc-desktop also need to be able to write files?

When you drag out files to save them or when you save them over the download button, it needs to write files.

@flub
Copy link
Collaborator

flub commented Apr 26, 2019

So you think restricting writing to the xdg-download dir is reasonable? Or would you rather do exactly what signal does and make $HOMO read-write instead of read-only? It's probably more intuitive for all of $HOME to be read-write as the other one is not really discoverable without UI help (and that probably won't happen as this is flatpak-specific)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants