Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.36.4 #109

Merged
merged 2 commits into from
Apr 25, 2023
Merged

update to 1.36.4 #109

merged 2 commits into from
Apr 25, 2023

Conversation

Simon-Laux
Copy link
Collaborator

@Simon-Laux Simon-Laux commented Apr 23, 2023

for me it failed multiple times locally complaining about missing npm dependencies, which ones you ask? that's random, because my instance of flatpak-node-generator is still non-deterministic and flaky, so the package that is missing changes with every run, I already had ms, js-tokens and wrappy missing.

I even updated the flathub build tools repo and installed flatpak-node-generator again with pipx.

@Simon-Laux Simon-Laux requested a review from muelli April 23, 2023 14:01
@flathubbot
Copy link

Started test build 37052

@flathubbot
Copy link

Build 37052 failed

I've used https://github.com/flatpak/flatpak-builder-tools as of
06e1d8050de79770f7701af137b4a0b2f5b3fed6
with this command line:
python3 -m flatpak_node_generator --recursive -s npm ~/vcs/deltachat-desktop/package-lock.json --output ~/vcs/deltachat-desktop.flatpak/generated-sources-npm
@flathubbot
Copy link

Started test build 37391

@flathubbot
Copy link

Build 37391 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/20035/chat.delta.desktop.flatpakref

@muelli
Copy link
Collaborator

muelli commented Apr 25, 2023

I've used https://github.com/flatpak/flatpak-builder-tools as of
06e1d8050de79770f7701af137b4a0b2f5b3fed6
with this command line:
python3 -m flatpak_node_generator --recursive -s npm ~/vcs/deltachat-desktop/package-lock.json --output ~/vcs/deltachat-desktop.flatpak/generated-sources-npm

@muelli muelli merged commit 0e640b9 into master Apr 25, 2023
@Simon-Laux Simon-Laux deleted the update-to-1.36.4 branch April 25, 2023 15:04
@missytake
Copy link

missytake commented May 2, 2023

Hm, unfortunately this introduced deltachat/deltachat-desktop#3221, as the core was prematurely updated to 1.114.0 - can we downgrade it to 1.112.8 and make a new flathub release?

@Simon-Laux
Copy link
Collaborator Author

made an issue so we don't forget #110

@muelli
Copy link
Collaborator

muelli commented May 2, 2023

oups. sorry. my bad :(
It's certainly possible to downgrade the d-c-c.

@Simon-Laux
Copy link
Collaborator Author

@muelli could you do a pr?

@muelli muelli mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants