Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.44 #125

Merged
merged 10 commits into from
Mar 6, 2024
Merged

update to 1.44 #125

merged 10 commits into from
Mar 6, 2024

Conversation

Simon-Laux
Copy link
Collaborator

@Simon-Laux Simon-Laux commented Feb 24, 2024

Observations:

Update: I solved both observations/issues

TODO

closes #118
closes deltachat/deltachat-desktop#2800

@flathubbot
Copy link

Started test build 102538

@flathubbot
Copy link

Started test build 102540

@flathubbot
Copy link

Build 102538 failed

@flathubbot
Copy link

Build 102540 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/85320/chat.delta.desktop.flatpakref

we don't need it as you can customize zoomlevel inside of deltachat desktop

downside: this also removes display scaling for the mouse pointer, but I think that is better than the blur
@flathubbot
Copy link

Started test build 104132

@flathubbot
Copy link

Started test build 104133

@flathubbot
Copy link

Build 104132 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86922/chat.delta.desktop.flatpakref

@flathubbot
Copy link

Build 104133 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86923/chat.delta.desktop.flatpakref

@flathubbot
Copy link

Started test build 105052

@Simon-Laux Simon-Laux marked this pull request as ready for review March 5, 2024 18:44
@Simon-Laux Simon-Laux requested a review from muelli March 5, 2024 18:45
@flathubbot
Copy link

Build 105052 failed

@flathubbot
Copy link

Started test build 105069

@flathubbot
Copy link

Build 105069 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87874/chat.delta.desktop.flatpakref

@flathubbot
Copy link

Started test build 105085

@flathubbot
Copy link

Build 105085 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87890/chat.delta.desktop.flatpakref

@muelli
Copy link
Collaborator

muelli commented Mar 6, 2024

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice.

I wonder how self-explanatory ELECTRON_OZONE_PLATFORM_HINT is. Neither the code nor the commit reveals why it's necessary so it could be difficult to assess when it's appropriate to remove it in the future.

But I don't block on those for merging, so feel free to merge.

@Mikaela
Copy link
Contributor

Mikaela commented Mar 6, 2024

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice.

The flathub validator bot rejects other device rules coexisting with device=all, so the alternative would be removing device=all and breaking qr code scanning in device linking.

I wonder how self-explanatory ELECTRON_OZONE_PLATFORM_HINT is. Neither the code nor the commit reveals why it's necessary so it could be difficult to assess when it's appropriate to remove it in the future.

I guess a comment linking to electron environment variables documentation and saying the app won't launch under wayland otherwise would be trivial to add.

chat.delta.desktop.yml Outdated Show resolved Hide resolved
@flathubbot
Copy link

Started test build 105192

chat.delta.desktop.yml Outdated Show resolved Hide resolved
@flathubbot
Copy link

Started test build 105193

@Simon-Laux
Copy link
Collaborator Author

Simon-Laux commented Mar 6, 2024

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice

It is unfortunate that there seems not to be a more specific way to access webcams, like a device=webcams/cameras or a portal that is so mature that it was added to Electron.

@flathubbot
Copy link

Build 105192 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87998/chat.delta.desktop.flatpakref

@flathubbot
Copy link

Build 105193 failed

@flathubbot
Copy link

Started test build 105196

@flathubbot
Copy link

Build 105196 was cancelled

@flathubbot
Copy link

Started test build 105197

@flathubbot
Copy link

Build 105197 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88003/chat.delta.desktop.flatpakref

@Simon-Laux Simon-Laux merged commit fb55de8 into master Mar 6, 2024
1 check passed
@Simon-Laux Simon-Laux deleted the beta-v1.43.1 branch March 6, 2024 11:31
@Simon-Laux Simon-Laux changed the title WIP: update to 1.44 update to 1.44 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global menu Wayland support
4 participants