-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to 1.44 #125
update to 1.44 #125
Conversation
Started test build 102538 |
Started test build 102540 |
Build 102538 failed |
Build 102540 successful
|
we don't need it as you can customize zoomlevel inside of deltachat desktop downside: this also removes display scaling for the mouse pointer, but I think that is better than the blur
Started test build 104132 |
Started test build 104133 |
Build 104132 successful
|
Build 104133 successful
|
Started test build 105052 |
Build 105052 failed |
Started test build 105069 |
Build 105069 successful
|
Started test build 105085 |
Build 105085 successful
|
I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice. I wonder how self-explanatory ELECTRON_OZONE_PLATFORM_HINT is. Neither the code nor the commit reveals why it's necessary so it could be difficult to assess when it's appropriate to remove it in the future. But I don't block on those for merging, so feel free to merge. |
The flathub validator bot rejects other device rules coexisting with device=all, so the alternative would be removing device=all and breaking qr code scanning in device linking.
I guess a comment linking to electron environment variables documentation and saying the app won't launch under wayland otherwise would be trivial to add. |
Started test build 105192 |
Started test build 105193 |
It is unfortunate that there seems not to be a more specific way to access webcams, like a |
Build 105192 successful
|
Build 105193 failed |
Started test build 105196 |
Build 105196 was cancelled |
Started test build 105197 |
Build 105197 successful
|
Observations:
Update: I solved both observations/issues
TODO
closes #118
closes deltachat/deltachat-desktop#2800