updated to v1.15.3 #52

This is inspired by flathub/com.irccloud.desktop@8e764be Let's see how well this works. The commit 394786b910a1d2ee35455210d923a360a425f03d of f-b-t says, that electron/get >= 1.12.4 has a new behaviour. But we don't have such a new version. Well, let's give this a try, anyway.

flathubbot · 2021-03-19T07:40:22Z

Started test build 42130

flathubbot · 2021-03-19T07:50:55Z

Build 42130 failed

muelli · 2021-03-19T09:35:48Z

dunno, really. Seems Electron is making trouble, somehow. Maybe 11.2 would help (currently, it seems to be pulling 11.1). At least, that's what seems to be working for flathub/com.irccloud.desktop@8e764be

I don't understand, how electron/get is pulled in, but it may help to have a newer version there, too.

Simon-Laux · 2021-03-19T14:11:28Z

so we should release an update that updates electron to 11.2?

muelli · 2021-03-19T14:18:13Z

yeah, I mean, I am out of ideas what causes npm to not find the downloaded dependencies :-/
But unless you plan on updating those dependencies anyway, a full release is probably heavy handed. We could probably get away with testing a fork or a branch, e.g. you update the deps in some branch and we try to build that branch.

Simon-Laux · 2021-03-19T15:09:39Z

there you are https://github.com/deltachat/deltachat-desktop/tree/1.15.x_electron_upgrade
maybe it could be also electron builder, I can also update that if this is not working

flathubbot · 2021-03-19T15:18:23Z

Started test build 42161

flathubbot · 2021-03-19T15:38:57Z

Build 42161 failed

This reverts commit 120f7c9.

Simon-Laux · 2021-03-19T16:06:21Z

updated electron builder in that branch

flathubbot · 2021-03-19T16:28:33Z

Started test build 42170

flathubbot · 2021-03-19T18:55:08Z

Build 42170 failed

python3 ~/vcs/flatpak-builder-tools/node/flatpak-node-generator.py npm ~/vcs/deltachat-desktop/package-lock.json --recursive -s --output generated-sources-npm.json

flathubbot · 2021-03-19T22:23:27Z

Started test build 42197

flathubbot · 2021-03-19T22:35:28Z

Build 42197 failed

This reverts commit 22755ff.

Forgive me, I have no idea, what I'm doing.

flathubbot · 2021-03-19T23:20:21Z

Build 42203 failed

flathubbot · 2021-03-19T23:20:32Z

Started test build 42205

flathubbot · 2021-03-19T23:25:41Z

Build 42204 failed

flathubbot · 2021-03-19T23:32:40Z

Build 42205 failed

muelli · 2021-03-19T23:44:07Z

Ouf, what a mess. Sorry.

Looks much better now:

npm info lifecycle deltachat-desktop@1.15.3~check-types: deltachat-desktop@1.15.3
> deltachat-desktop@1.15.3 check-types /run/build/delta
> tsc -b src/check-all-tsconfig.json
src/main/deltachat/controller.ts:24:42 - error TS2307: Cannot find module '../../shared/build-info' or its corresponding type declarations.
24 import { VERSION, BUILD_TIMESTAMP } from '../../shared/build-info'
                                            ~~~~~~~~~~~~~~~~~~~~~~~~~
src/main/index.ts:6:51 - error TS2307: Cannot find module '../shared/build-info' or its corresponding type declarations.

Looks like it has been forgotten to add build:shared:version to "build4production" :-/

That script turns out to be fragile:

> deltachat-desktop@1.15.3 build:shared:version /run/build/delta
> node ./bin/build-shared-version-info.js

Error: fatal: No tags can describe '66e91dbf50b7a49f97e874976a8b4a31bae030ba'.
Try --always, or create some tags.

    at gatherProcessStdout (/run/build/delta/bin/build-shared-version-info.js:7:27)

Simon-Laux · 2021-03-20T11:27:14Z

Looks like it has been forgotten to add build:shared:version to "build4production" :-/

npm run build4production runs npm run build which runs npm run build:shared which runs npm run build:shared:version

the script tries a 3 methods of getting a git reference. Did all of them fail? maybe we need a special case for flatpak or its really unstable.

looking up that error I found this stackoverflow answer https://stackoverflow.com/questions/6445148/git-fatalno-tags-can-describe-sha1-number/6445255#6445255 which suggests to do a git fetch before running git describe

muelli · 2021-03-20T17:00:45Z

Looks like it has been forgotten to add build:shared:version to "build4production" :-/

npm run build4production runs npm run build which runs npm run build:shared which runs npm run build:shared:version

yeah, you're right. But calling check types fails:

package.json:    "check-types": "tsc -b src/check-all-tsconfig.json",
package.json:    "build4production": "npm run check-types && NODE_ENV=\"production\" npm run build",

And by the time check types is run, the build hasn't yet been performed, so the shared thing hasn't been built either.

It seems that the Electron update is not necessary. At least the npm install step seems to succeed.

This seems to be required in order for build4production to run.

flathubbot · 2021-03-20T18:12:39Z

Started test build 42313

flathubbot · 2021-03-20T18:27:06Z

Build 42313 failed

This tries to find out why it can't find the zip files it's looking for. Because they sort of exist! Interestingly, it looks for both ../chromedriver-v10.0.0-linux-x64.zip and ../electron-v11.1.0-linux-x64.zip.

flathubbot · 2021-03-22T09:35:07Z

Started test build 42400

muelli · 2021-03-22T09:36:37Z

  • async task error  error=ENOENT: no such file or directory, symlink '../electron-v11.1.0-linux-x64.zip' -> '/run/build/delta/dist/linux-unpacked/resources/app/flatpak-node/cache/electron/httpsgithub.comelectronelectronreleasesdownloadv11.1.0electron-v11.1.0-linux-x64.zip/electron-v11.1.0-linux-x64.zip'
  ⨯ ENOENT: no such file or directory, symlink '../electron-v11.1.0-linux-x64.zip' -> '/run/build/delta/dist/linux-unpacked/resources/app/flatpak-node/cache/electron/httpsgithub.comelectronelectronreleasesdownloadv11.1.0electron-v11.1.0-linux-x64.zip/electron-v11.1.0-linux-x64.zip'  stackTrace=

that's strange, because the file does indeed exist.

$ find .flatpak-builder/build/delta/ -name 'electron-v11.1.0-linux-x64.zip'
.flatpak-builder/build/delta/flatpak-node/cache/electron/electron-v11.1.0-linux-x64.zip
.flatpak-builder/build/delta/flatpak-node/cache/electron/httpsgithub.comelectronelectronreleasesdownloadv11.1.0electron-v11.1.0-linux-x64.zip/electron-v11.1.0-linux-x64.zip
.flatpak-builder/build/delta/flatpak-node/cache/electron/27ec2e86c437e8c9412011714f7c9847e193de54b5a2500afbd4406799c299cc/electron-v11.1.0-linux-x64.zip
.flatpak-builder/build/delta/dist/linux-unpacked/resources/app/flatpak-node/cache/electron/electron-v11.1.0-linux-x64.zip

So somehow it seems to look for the file in the wrong place. If the CWD line in the log is indeed correct, i.e. CWD: /run/build/delta, then, sure, ../electron-v11.1.0-linux-x64.zip doesn't exist. strace seems to confirm that the working directory hasn't changed. Weird then.

Note how it seems to be looking for both chromedriver and electron.

flathubbot · 2021-03-22T09:48:16Z

Build 42400 failed

Simon-Laux · 2021-03-23T00:36:28Z

did the electron upgrade help?

flathubbot · 2021-03-23T13:32:05Z

Started test build 42517

flathubbot · 2021-03-23T13:45:45Z

Build 42517 failed

muelli · 2021-03-23T21:30:08Z

no :(

Other apps use electron-builder-22, so it should work, I guess. They use yarn, though, but I don't think it should matter too much here, because the failure is past installation stage.
I don't understand where electron-builder is looking for those files and, consequently, how to convince it to take the files that we have.

Simon-Laux · 2021-03-23T22:18:06Z

log looks to me like it looks in /run/build/delta/dist/linux-unpacked/resources/app/flatpak-node/cache/electron/httpsgithub.comelectronelectronreleasesdownloadv11.3.0electron-v11.3.0-linux-x64.zip/electron-v11.3.0-linux-x64.zip?

anyways in the future we might be able to use electron-userland/electron-builder#5711, maybe you can try a build using it in a separate branch (install the branch of the electron builder pullrequest) 🤷

muelli · 2021-03-23T22:22:29Z

log looks to me like it looks in /run/build/delta/dist/linux-unpacked/resources/app/flatpak-node/cache/electron/httpsgithub.comelectronelectronreleasesdownloadv11.3.0electron-v11.3.0-linux-x64.zip/electron-v11.3.0-linux-x64.zip?

Hm. How do you arrive at that conclusion? That's the target, no?

anyways in the future we might be able to use electron-userland/electron-builder#5711, maybe you can try a build using it in a separate branch (install the branch of the electron builder pullrequest) shrug

Hm. No, I don't think this is relevant. Notice how the description also mentions that flathub is future work.

Simon-Laux · 2021-03-27T11:46:10Z

Hm. How do you arrive at that conclusion? That's the target, no?

this section in the log:

  • async task error  error=ENOENT: no such file or directory, symlink '../electron-v11.3.0-linux-x64.zip' -> '/run/build/delta/dist/linux-unpacked/resources/app/flatpak-node/cache/electron/httpsgithub.comelectronelectronreleasesdownloadv11.3.0electron-v11.3.0-linux-x64.zip/electron-v11.3.0-linux-x64.zip'
  ⨯ ENOENT: no such file or directory, symlink '../electron-v11.3.0-linux-x64.zip' -> '/run/build/delta/dist/linux-unpacked/resources/app/flatpak-node/cache/electron/httpsgithub.comelectronelectronreleasesdownloadv11.3.0electron-v11.3.0-linux-x64.zip/electron-v11.3.0-linux-x64.zip'  stackTrace=

muelli · 2021-03-27T11:49:22Z

yeah, and I read it as if it's trying to symlink from ../electron-v11.3.0-linux-x64.zip to the path you mentioned. So I don't read it so that it's looking for the file in the place you said.

I don't know how to proceed here. Let's hope @refi64 has seen this type of failure before and knows what to do.

muelli · 2021-06-05T14:22:18Z

this has been superseded

updated to v1.15.3

d0b840e

updated chromedriver to 10.0.0 as it seems to be required

eedbe53

muelli force-pushed the v1.15.3 branch from 90206ab to eedbe53 Compare March 18, 2021 21:35

remove manual chromedriver

faf2d73

The generator should handle this. Let's see whether this works.

try with a newer Electron

045d677

Revert "Try xdg-layout for making it build with Electron-11"

22755ff

This reverts commit 120f7c9.

try with newer electron builder

381903b

python3 ~/vcs/flatpak-builder-tools/node/flatpak-node-generator.py npm ~/vcs/deltachat-desktop/package-lock.json --recursive -s --output generated-sources-npm.json

Revert "Revert "Try xdg-layout for making it build with Electron-11""

3bac39f

This reverts commit 22755ff.

handle esbuild

86cdd11

Forgive me, I have no idea, what I'm doing.

muelli added 2 commits March 20, 2021 19:10

revert to the released version

65980b3

It seems that the Electron update is not necessary. At least the npm install step seems to succeed.

manually call build:shared:version

ffb7dc8

This seems to be required in order for build4production to run.

debug: do not merge - strace npm

083fa71

This tries to find out why it can't find the zip files it's looking for. Because they sort of exist! Interestingly, it looks for both ../chromedriver-v10.0.0-linux-x64.zip and ../electron-v11.1.0-linux-x64.zip.

Simon-Laux mentioned this pull request Mar 23, 2021

fix build4production to work on its own deltachat/deltachat-desktop#2194

Merged

manually update the electron version

8e05530

Simon-Laux mentioned this pull request Mar 24, 2021

[Progress] Release 1.15.4 / 1.15.5 deltachat/deltachat-desktop#2187

Closed

5 tasks

Simon-Laux mentioned this pull request Apr 27, 2021

enable arm and aarch64 builds so it works on Raspberry Pi, PinePhone, LIbrem5, ARM laptops, etc. #48

Closed

muelli closed this Jun 5, 2021

updated to v1.15.3 #52

updated to v1.15.3 #52

Conversation

muelli commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 18, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

muelli commented Mar 19, 2021

Simon-Laux commented Mar 19, 2021

muelli commented Mar 19, 2021

Simon-Laux commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

Simon-Laux commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

flathubbot commented Mar 19, 2021

muelli commented Mar 19, 2021

Simon-Laux commented Mar 20, 2021 • edited

muelli commented Mar 20, 2021

flathubbot commented Mar 20, 2021

flathubbot commented Mar 20, 2021

flathubbot commented Mar 22, 2021

muelli commented Mar 22, 2021

flathubbot commented Mar 22, 2021

Simon-Laux commented Mar 23, 2021

flathubbot commented Mar 23, 2021

flathubbot commented Mar 23, 2021

muelli commented Mar 23, 2021

Simon-Laux commented Mar 23, 2021

muelli commented Mar 23, 2021

Simon-Laux commented Mar 27, 2021 • edited

muelli commented Mar 27, 2021

muelli commented Jun 5, 2021

Simon-Laux commented Mar 20, 2021 •

edited

Simon-Laux commented Mar 27, 2021 •

edited