This repository has been archived by the owner on May 24, 2024. It is now read-only.
Update metadata screenshot to an actual image of the browser #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would use a snap screenshot of vanilla chromium
|
Started test build 93809 |
|
Build 93809 failed |
|
Can you send this screenshot to upstream? It's better to use screenshots that come directly from upstream. |
|
Thank you! |
what do you mean? |
|
@networkException I think he wants you to host the screenshot in the main project (https://github.com/eloston/ungoogled-chromium) instead. So you could update the screenshot in one place and we would get the changes. |
|
Ah sure we can do that |
networkException
added a commit
to networkException/ungoogled-chromium
that referenced
this pull request
May 30, 2022
This patch adds a screenshot of the browser to the about page to be used by different platforms in store fronts See flathub/com.github.Eloston.UngoogledChromium#59
networkException
added a commit
to networkException/ungoogled-chromium
that referenced
this pull request
May 30, 2022
This patch adds a screenshot of the browser to the about page to be used by different platforms in store fronts See flathub/com.github.Eloston.UngoogledChromium#59
networkException
added a commit
to networkException/ungoogled-chromium
that referenced
this pull request
May 30, 2022
This patch adds two screenshots of the browser to the about page to be used by different platforms in store fronts See flathub/com.github.Eloston.UngoogledChromium#59
Just to confirm, yes, that's exactly what I want. |
networkException
added a commit
to networkException/ungoogled-chromium
that referenced
this pull request
Jun 24, 2023
This patch adds two screenshots of the browser of the welcoem page to be used by different platforms, for example as images in app stores. See flathub/com.github.Eloston.UngoogledChromium#59
networkException
added a commit
to networkException/ungoogled-chromium
that referenced
this pull request
Jun 24, 2023
This patch adds two screenshots of the browser of the welcome page to be used by different platforms, for example as images in app stores. See flathub/com.github.Eloston.UngoogledChromium#59
rany2
added a commit
to ungoogled-software/ungoogled-chromium-flatpak
that referenced
this pull request
Mar 30, 2024
This patch adds three screenshots of the browser of the about and welcome page to be used by different platforms, for example as images in app stores. See flathub/com.github.Eloston.UngoogledChromium#59 Co-authored-by: rany <ranygh@riseup.net> Signed-off-by: rany <ranygh@riseup.net>
rany2
added a commit
to ungoogled-software/ungoogled-chromium-flatpak
that referenced
this pull request
Mar 30, 2024
This patch adds three screenshots of the browser of the about and welcome page to be used by different platforms, for example as images in app stores. See flathub/com.github.Eloston.UngoogledChromium#59 Co-authored-by: rany <ranygh@riseup.net> Signed-off-by: rany <ranygh@riseup.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would use a snap screenshot of vanilla chromium (which is a bit cursed)