Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code editor checks and settings #82

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix code editor checks and settings #82

merged 1 commit into from
Jan 11, 2023

Conversation

priahoud
Copy link
Contributor

@priahoud priahoud commented Jan 1, 2023 •
edited
Loading

  • Disables explicit setting of Project file generation flags (works fine without any setting and should generally not override the users preference)
  • Replaces the old Extension ID "ms-vscode.csharp" with the new "ms-dotnettools.csharp"
  • Switches the old Omnisharp "useGlobalMono" setting to the new "useModernNet" one
  • Updates the Mono SDK Extension to Version 6 (old settings would show the warning dialog every time the code editor would be spawned)

@flathubbot
Copy link
Contributor

Started test build 14527

@flathubbot
Copy link
Contributor

Build 14527 failed

@flathubbot
Copy link
Contributor

Started test build 14530

@flathubbot
Copy link
Contributor

Build 14530 failed

This was referenced Jan 1, 2023
Closed
Merged
@FullStackFlamingo
Copy link

Wow, thanks so much @priahoud for doing the work to get Unity development working on flatpak again! Really appreciate it.
I was going to start the new year by attempting this, but I see you've beat me to it on flathub/org.freedesktop.Sdk.Extension.mono6#13

@priahoud
Copy link
Contributor Author

priahoud commented Jan 2, 2023 •
edited
Loading

Wow, thanks so much @priahoud for doing the work to get Unity development working on flatpak again! Really appreciate it. I was going to start the new year by attempting this, but I see you've beat me to it on flathub/org.freedesktop.Sdk.Extension.mono6#13

Thank you! Good to know I am not the only one that wants to see it working again.

@priahoud
Copy link
Contributor Author

priahoud commented Jan 2, 2023

bot, build

@flathubbot
Copy link
Contributor

Queued test build for com.unity.UnityHub.

@flathubbot
Copy link
Contributor

Started test build 14667

@flathubbot
Copy link
Contributor

Build 14667 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127089/com.unity.UnityHub.flatpakref

@FullStackFlamingo FullStackFlamingo mentioned this pull request Jan 5, 2023
Open
refi64
refi64 reviewed Jan 7, 2023
View reviewed changes
unityhub.py Outdated Show resolved Hide resolved
@priahoud
Fix code editor checks and settings
6859f23 
- Removes explicit setting of Project file generation flags (works fine without any setting and should generally not override the users preference)
- Replaces the old Extension ID "ms-vscode.csharp" with the new "ms-dotnettools.csharp"
- Switches the old Omnisharp "useGlobalMono" setting to the new "useModernNet" one
- Updates the Mono SDK Extension to Version 6 (old settings would show the warning dialog every time the code editor would be spawned)
@flathubbot
Copy link
Contributor

Started test build 16061

@flathubbot
Copy link
Contributor

Build 16061 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/128485/com.unity.UnityHub.flatpakref

@refi64 refi64 merged commit 386e9f4 into flathub:master Jan 11, 2023
@refi64
Copy link
Collaborator

refi64 commented Jan 11, 2023

thanks!

@priahoud priahoud deleted the fix-code-editor branch January 11, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refi64 refi64 refi64 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priahoud @flathubbot @FullStackFlamingo @refi64