Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to modify product.json #90

Closed
itspngu opened this issue Mar 12, 2022 · 5 comments
Closed

Document how to modify product.json #90

itspngu opened this issue Mar 12, 2022 · 5 comments
Assignees

Comments

@itspngu
Copy link

itspngu commented Mar 12, 2022

I just spent about half an hour reading through Github issues and source code of VSCode & VSCodium to figure out how to get Pylance working. In short:

  • The workaround described here suggests editing a product.json file, but find $HOME/.var/app/com.vscodium.codium -name 'product.json' returns nothing
  • Found product.json should be editable #22 which links to customize the extensions gallery VSCodium/vscodium#674
  • The linked PR contains a patch which looks for a user-provided product.json to merge into the compiled-in values - by default, no product.json is included in shipped builds
  • Dropping the following file into $HOME/.var/app/com.vscodium.codium/config/VSCodium/product.json lets me run Pylance:
{
  "nameShort": "Visual Studio Code",
  "nameLong": "Visual Studio Code",
  "extensionsGallery": {
    "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
    "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
    "itemUrl": "https://marketplace.visualstudio.com/items"
  }
}

As this is a rather specific workaround to a specific problem, perhaps just including a note somewhere is enough to spare others from having to go through the same journey.

@noonsleeper
Copy link
Collaborator

Hey @itspngu, will be great if you make a PR about it! =)

@wiraki
Copy link

wiraki commented Oct 21, 2022

Just here to say that if I am not mistaken, this is technically illegal.

@bxff
Copy link

bxff commented Dec 8, 2022

Also refer: VSCodium/vscodium#940 (comment)

@r1jsheth
Copy link

r1jsheth commented Jan 3, 2023

Just here to say that if I am not mistaken, this is technically illegal.

@mpauper very curious being a newbie, how is it technically illegal to document this?

@GitMensch
Copy link

While I think you are kidding even without an explicit smiley: anyone is free to document this, but both using Pylanc and the MS marketplace means you need to follow their license - which explicit says that the license only allows those to be used with Microsoft products (and Microsoft made quite clear that "vscode-oss builds" don't match that description).

It would therefore be most reasonable to document that instead of any hacks one should use https://github.com/flathub/com.visualstudio.code if one wants to use these Microsoft services and (binary-only distributed) extensions.

@noonsleeper noonsleeper self-assigned this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants