New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome Ring #126
Gnome Ring #126
Conversation
Split the files for better readability Moved to release from 13th september 2017 Few tweak and optimizations
@@ -0,0 +1,142 @@ | |||
{ | |||
"app-id": "cx.ring.Ring", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed from cx.ring.RingGnome due to the fact that all interfaces and services are registered to cx.ring.Ring.
"--filesystem=xdg-run/dconf", | ||
"--filesystem=~/.config/dconf:ro", | ||
"--talk-name=ca.desrt.dconf", | ||
"--own-name=cx.ring.RingGnome", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This named is also needed by the application
Could you guys please run a test build for this. I tested it x86_64, but I want to be sure of arm and aarch64 |
Test build https://flathub.org/builds/#/buildrequests/3627?redirect_to_build=true (sorry for the previous one, I put in the wrong appid) |
Looks like dbus-c++ needs a manual reconfigure to identify what an aarch64 machine is. Here's an example of how to specify that from another manifest. |
Please run a test build |
Test build running here: https://flathub.org/builds/#/builders/1/builds/676 |
cx.ring.RingDaemon.json
Outdated
] | ||
}, | ||
{ | ||
"name": "dbus-c++", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should've been more clear here. This also needs "rm-configure": true,
in order to work on aarch64. I've just built down to that part on a scaleway aarch4 system so I know that'll work ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks will do it
Other than the rm-configure, the other failures aren't your fault @alexlarsson is investigating. |
Can you please trigger a build once libpulsecommon.so is fixed... |
Arm build failed. Will fix after going home. |
OK, so 32 bit ARM works now, Aarch64 still fails though, I think you can safely ignore the x86-64 fail in the last build as that looks transient. |
aarch64 failure is because linker is not able to find libpulsecommon.so. This was something that was present in other ARCHs as well, but was fixed when Sdk was updated |
cx.ring.libRingClient.json
Outdated
"-no-pch", | ||
"-no-rpath", | ||
"-no-separate-debug-info", | ||
"-reduce-relocations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is different to the KDE runtime's version and seems to be causing a build failure on aarch64.
Ran another test build: https://flathub.org/builds/#/builders/1/builds/937 Fails on aarch64 with some stuff about reduce relocations in qt5. Your settings are different to the KDE Runtime, which only enables that configure opt for x86-64, may be worth copying their configuration unless you need something that's different. |
Can you trigger another build. Sorry for late commit, was a little busy. Also I don't know if the build will go through, since I wasn't able to confirm it. |
Please trigger another build, this should have fixed i386, x86_64 and arm builds. I have made changes for aarch64 as well, but would like to see the status of the build |
Please trigger a build, this should have fixed build issues with x86_64, i686 and arm |
bot, build cx.ring.Ring |
aarch64 still fails on qrencode |
Please trigger a build, I have moved qrencode to CMake. Hope this fixes issues with aarch64. If not I am disabling aarch64 |
cx.ring.Ring.json
Outdated
@@ -11,6 +11,7 @@ | |||
"--share=network", | |||
"--device=all", | |||
"--share=ipc", | |||
"--extension=org.freedesktop.Plaform.VAAPI=version=1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this, that extension point comes with the runtime you depend upon
bot, build cx.ring.Ring |
Repository has been created: https://github.com/flathub/cx.ring.Ring |
Add Window Startup class
Update Godot to 4.1 (flathub#126)
A GPLv3 VoIP and video chat client. Website https://ring.cx/