Add org.sugarlabs.BaseApp

[tchx84]

NOTICE: This is still work on progress.

[tchx84]

bot, build org.sugarlabs.BaseApp

[flathubbot]

Queued test build for org.sugarlabs.BaseApp.

[flathubbot]

Started test build 14017

[bilelmoussaoui]

You need a flathub.json with skip-appstream-check set to true like https://github.com/flathub/io.elementary.BaseApp/blob/branch/juno-19.08/flathub.json.

[tchx84]

A few questions for reviewers:

1. All of these apps will use "command": "sugarapp" to run, but it seems I still have to specify it per app. Is there another way to achieve / workaround it?

2. Similar to the above question, but for "finish-args".

[flathubbot]

Build 14017 failed

[tchx84]

You need a flathub.json with skip-appstream-check set to true like https://github.com/flathub/io.elementary.BaseApp/blob/branch/juno-19.08/flathub.json.

Thanks!

[tchx84]

bot, build org.sugarlabs.BaseApp

[flathubbot]

Queued test build for org.sugarlabs.BaseApp.

[flathubbot]

Started test build 14018

[bilelmoussaoui]

A few questions for reviewers:

1. All of these apps will use `"command": "sugarapp"` to run, but it seems I still have to specify it per app. Is there another way to achieve / workaround it?

2. Similar to the above question, but for `"finish-args"`.

I think it's better to keep those at the application level

[flathubbot]

Build 14018 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/13374/org.sugarlabs.BaseApp.flatpakref

[tchx84]

I am still deciding whether to use a separate branch (E.g. "0.116" following the sugar release it's based on) or just leave it "stable"... on one hand, I really don't want to overpopulate with many BaseApp versions that will get dropped fast, on the other hand I think making updates too rigid could have risks, but considering current Sugar development state, it's extremely unlikely that future releases will break compatibility at this point.

So, I am leaning towards just having one "stable" branch.

@TingPing @nedrichards @barthalion @bilelmoussaoui any suggestions?

[nedrichards]

this is honestly my biggest concern around using baseapps for this kind of workflow. Pragmatically I think it's OK to track a 'stable' but overall I don't like the loss of declarativeness on the app by app level, and it will need co-ordination across all users if it changes.

[tchx84]

this is honestly my biggest concern around using baseapps for this kind of workflow. Pragmatically I think it's OK to track a 'stable' but overall I don't like the loss of declarativeness on the app by app level, and it will need co-ordination across all users if it changes.

I see that too.

Also, I realized that the runtime needs to be defined both in the BaseApp and in every app using that BaseApp. So, I am not exactly sure how the workflow would work if I only have one stable branch. There will be a delay between bumping the runtime version in the BaseApp and then in every app. So. I am not completely sure if having (even if only temporarily) different runtime versions (BaseApp vs app) could cause unexpected/unforeseen issues.

[tchx84]

bot, build org.sugarlabs.BaseApp

[flathubbot]

Queued test build for org.sugarlabs.BaseApp.

[flathubbot]

Started test build 18553

[flathubbot]

Build 18553 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/17788/org.sugarlabs.BaseApp.flatpakref

[tchx84]

@bilelmoussaoui how can I get this merged without triggering a build and publish job? I need to mimic what Elementary does of just having a "20.04" branch, and not really a "stable" one.

Mind explaining how these branches are managed in Flathub infra?

[bilelmoussaoui]

@bilelmoussaoui how can I get this merged without triggering a build and publish job? I need to mimic what Elementary does of just having a "20.04" branch, and not really a "stable" one.

Mind explaining how these branches are managed in Flathub infra?

We can since #1256 (comment) create a repository and default to an other branch than master . The master branch is what used for stable releases

[bilelmoussaoui]

It looks good to me, let us know and we can merge it to branch/20.04

[tchx84]

@bilelmoussaoui great, please do merge.

[bilelmoussaoui]

/merge:branch/20.04

[flathubbot]

A repository for this has been created: https://github.com/flathub/org.sugarlabs.BaseApp

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

[barthalion]

(For the record, merge:20.04, without branch/ prefix.)

[bilelmoussaoui]

(For the record, merge:20.04, without branch/ prefix.)

We don't need branch/ prefix anymore?

[barthalion]

Yeah, the code adds branch/ to anything that isn't beta.