com.visualstudio.code #150

nedrichards · 2017-11-13T16:56:19Z

Extra-data based flatpak for Visual Studio Code (since the source code based edition has both bitrotted and depends on us getting network free electron builds). Furthermore, there is value in providing the official, closed source packages with MS keys etc. If we wanted to migrate to the free software version, or offer it then it'd be with the com.visualstudio.code.oss App ID.

This doesn't use the new syntax for extra-data since Endless hasn't updated it's version of flatpak beyond 0.9.8 yet so I can't test it.

nedrichards · 2017-11-13T16:57:23Z

Test build: https://flathub.org/builds/#/builders/1/builds/942

TingPing · 2017-11-13T18:05:02Z

com.visualstudio.code.json

+            "type": "archive",
+            "url": "https://www.x.org/releases/individual/lib/libxkbfile-1.0.9.tar.bz2",
+            "sha256": "51817e0530961975d9513b773960b4edd275f7d5c72293d5a151ed4f42aeb16a"
+        }


whitespace.

TingPing · 2017-11-13T18:06:21Z

com.visualstudio.code.json

+                    "cp share/pixmaps/code.png export/share/icons/hicolor/512x512/apps/com.visualstudio.code.png",
+                    "mkdir -p export/share/applications",
+                    "cp share/applications/code.desktop export/share/applications/com.visualstudio.code.desktop",                
+                    "desktop-file-edit --set-key=Exec --set-value='code %F' export/share/applications/com.visualstudio.code.desktop",


~~desktop-file-edit isn't in the runtime.~~ Nevermind this runs off the Sdk...

TingPing · 2017-11-13T18:06:47Z

com.visualstudio.code.json

+                    "mv usr/* .",
+                    "rmdir usr",
+                    "mkdir -p export/share/icons/hicolor/512x512/apps",
+                    "cp share/pixmaps/code.png export/share/icons/hicolor/512x512/apps/com.visualstudio.code.png",


Can be combined into a install -Dm644 ... command.

Also since you are copying this it leaves a duplicate around you can remove, same applies for desktop and appdata.

TingPing · 2017-11-13T18:41:55Z

com.visualstudio.code.json

+        ]
+    },
+    {
+        "name": "nodejs",


Probably reasonable to clean up: /include /share /lib/node_modules/npm/changelogs /lib/node_modules/npm/doc /lib/node_modules/npm/html /lib/node_modules/npm/man /lib/node_modules/npm/scripts, etc

TingPing · 2017-11-13T18:43:26Z

com.visualstudio.code.json

+        ]
+    },
+    {
+        "name": "git",


Can probably cleanup: /share/git-gui

TingPing · 2017-11-13T18:45:47Z

com.visualstudio.code.json

+                "commands": [
+                    "ar x code.deb",
+                    "rm -f code.deb",                    
+                    "tar -xf data.tar.xz",


Forgot to delete this.

TingPing · 2017-11-13T18:47:05Z

com.visualstudio.code.json

+                    "desktop-file-edit --set-key=Exec --set-value='code %F' export/share/applications/com.visualstudio.code.desktop",
+                    "desktop-file-edit --set-key=Icon --set-value='com.visualstudio.code' export/share/applications/com.visualstudio.code.desktop",                    
+                    "mkdir -p export/share/appdata",
+                    "sed s/code.desktop/com.visualstudio.code.desktop/ share/appdata/code.appdata.xml > export/share/appdata/com.visualstudio.code.appdata.xml"        


The license of this is incorrect:

<metadata_license>Multiple, see https://code.visualstudio.com/license</metadata_license> <project_license>Multiple, see https://code.visualstudio.com/license</project_license>

It should be LicenseRef-proprietary=https://code.visualstudio.com/license

Also its valuable for us to add <releases>.

I mean, this is upstream appdata. I'm always reluctant to override that where not actually necessary - but fair enough on the proprietary thing.

I'll open an issue upstream on this and the front, they've seemed pretty responsive to suggestions and patches thus far and I don't want to patch that downstream if possible since it's a bit fragile with a frequently released app..

Yea, the license fix is required but for releases reasonable to get upstream to do it.

TingPing · 2017-11-13T18:57:11Z

This still writes to ~/.vscode, it would be nice to override that if possible.

EDIT: Having the script run /app/extra/share/code/bin/code --extensions-dir=$XDG_DATA_HOME/vscode/extensions is a start.

Also shipping npm bundled has its own nightmare of paths to override:

nedrichards · 2017-11-14T03:26:39Z

We should think about adding some of this dotfile stuff to the Review Guidelines because we basically don't talk about sandboxing and permissions at all there.

nedrichards · 2017-11-16T16:48:43Z

OK, that should cover the first review. ;-)

nedrichards · 2017-11-16T16:49:21Z

Test build: https://flathub.org/builds/#/builders/1/builds/1000

TingPing · 2017-11-16T18:24:00Z

com.visualstudio.code.json

+                    "desktop-file-edit --set-key=Exec --set-value='code %F' export/share/applications/com.visualstudio.code.desktop",
+                    "desktop-file-edit --set-key=Icon --set-value='com.visualstudio.code' export/share/applications/com.visualstudio.code.desktop",                    
+                    "mkdir -p export/share/appdata",
+                    "sed -e s/code.desktop/com.visualstudio.code.desktop/ -e 's/Multiple, see /LicenseRef-proprietary=/' share/appdata/code.appdata.xml > export/share/appdata/com.visualstudio.code.appdata.xml"        


's/Multiple, see /LicenseRef-proprietary=/'

s/.../.../g since it has multiple matches

nedrichards · 2017-11-16T21:37:34Z

Ugh, so I don't think using the appdata from inside the package can work - since it's extra-data that means that the package fails the flathub validation. So I'm going to fork the open source version's appdata, modify the Licence of the binary and add versions tags as suggested.

Such is life.

nedrichards · 2017-11-16T21:54:48Z

Newer build, now with appdata, hopefully https://flathub.org/builds/#/builders/1/builds/1003

TingPing · 2017-11-16T23:43:31Z

com.visualstudio.code.appdata.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop">
+	<id>com.visualstudio.code.desktop</id>
+	<metadata_license>Multiple, see https://code.visualstudio.com/license</metadata_license>


This should be the same syntax as project_license.

One problem though is this license would then not be distributable, but.. the same appdata file is under a different license if the foss version is built...

upstream really needs to fix this.

Right, I'm going to update the metadata to be under the MIT, which is where I've 'forked' it from for these purposes.

amtlib-dot-dll · 2017-11-17T03:23:31Z

@nedrichards Well I am using my cloud-built version of code-oss now https://github.com/amtlib-dot-dll/vscode-build-travis/blob/master/.travis.yml https://github.com/amtlib-dot-dll/vscode-build-travis/tree/out but yeah you are right we need to do some work to achieve offline and reproducible builds.

nedrichards · 2017-11-20T18:15:57Z

Another (hopefully final) test build: https://flathub.org/builds/#/builders/1/builds/1028

TingPing · 2017-11-21T01:42:14Z

Repository has been created: https://github.com/flathub/com.visualstudio.code

Initial commit for VS Code

594c991

TingPing reviewed Nov 13, 2017

View reviewed changes

com.visualstudio.code.json Outdated

]

},

{

"name": "git",

Copy link

Member

TingPing Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably cleanup: /share/git-gui

TingPing reviewed Nov 13, 2017

View reviewed changes

com.visualstudio.code.json

"commands": [

"ar x code.deb",

"rm -f code.deb",

"tar -xf data.tar.xz",

Copy link

Member

TingPing Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to delete this.

TingPing reviewed Nov 13, 2017

View reviewed changes

TingPing added the awaiting-changes Pull request waiting for inputs or changes from author label Nov 13, 2017

robinst mentioned this pull request Nov 14, 2017

Offer Flatpak as Linux installation option microsoft/vscode#7112

Closed

Nick Richards added 2 commits November 15, 2017 16:03

address first round of feedback

f10856d

Update to fix review feedback

80bbd1b

nedrichards removed the awaiting-changes Pull request waiting for inputs or changes from author label Nov 16, 2017

TingPing reviewed Nov 16, 2017

View reviewed changes

fix sed to match multiply

a05f91e

Nick Richards added 2 commits November 16, 2017 21:42

switch to external appdata

f1eb789

add oars rating to appdata

8341c52

TingPing reviewed Nov 16, 2017

View reviewed changes

make clear that the appdata metadata is under the MIT

0bf84e2

TingPing closed this Nov 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

com.visualstudio.code #150

com.visualstudio.code #150

nedrichards commented Nov 13, 2017 •

edited by TingPing

Loading

nedrichards commented Nov 13, 2017

TingPing Nov 13, 2017

TingPing Nov 13, 2017 •

edited

Loading

TingPing Nov 13, 2017

TingPing Nov 13, 2017 •

edited

Loading

TingPing Nov 13, 2017

TingPing Nov 13, 2017

TingPing Nov 13, 2017

TingPing Nov 13, 2017 •

edited

Loading

TingPing Nov 13, 2017

nedrichards Nov 14, 2017

TingPing Nov 14, 2017

TingPing commented Nov 13, 2017 •

edited

Loading

nedrichards commented Nov 14, 2017

nedrichards commented Nov 16, 2017

nedrichards commented Nov 16, 2017

TingPing Nov 16, 2017

nedrichards Nov 16, 2017

nedrichards commented Nov 16, 2017

nedrichards commented Nov 16, 2017 •

edited

Loading

TingPing Nov 16, 2017

TingPing Nov 16, 2017

nedrichards Nov 20, 2017

amtlib-dot-dll commented Nov 17, 2017

nedrichards commented Nov 20, 2017

TingPing commented Nov 21, 2017

com.visualstudio.code #150

com.visualstudio.code #150

Conversation

nedrichards commented Nov 13, 2017 • edited by TingPing Loading

nedrichards commented Nov 13, 2017

Choose a reason for hiding this comment

TingPing Nov 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TingPing Nov 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TingPing Nov 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TingPing commented Nov 13, 2017 • edited Loading

nedrichards commented Nov 14, 2017

nedrichards commented Nov 16, 2017

nedrichards commented Nov 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nedrichards commented Nov 16, 2017

nedrichards commented Nov 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amtlib-dot-dll commented Nov 17, 2017

nedrichards commented Nov 20, 2017

TingPing commented Nov 21, 2017

nedrichards commented Nov 13, 2017 •

edited by TingPing

Loading

TingPing Nov 13, 2017 •

edited

Loading

TingPing Nov 13, 2017 •

edited

Loading

TingPing Nov 13, 2017 •

edited

Loading

TingPing commented Nov 13, 2017 •

edited

Loading

nedrichards commented Nov 16, 2017 •

edited

Loading