Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.jitsi.jitsi-meet #1690

Closed
wants to merge 5 commits into from
Closed

Conversation

ananace
Copy link

@ananace ananace commented Aug 2, 2020

Upstream has been asked about Flatpak support [1][2], but are currently not willing to spend their own limited time on setting up and maintaining a second Linux build pipeline (understandably seeing the lack of Flatpak support in electron-builder), so I've here written up a manifest that uses unappimage to repackage their existing AppImage build into a Flatpak.
That way, people who want to use Jitsi Meet's desktop app without manually handling their AppImage will still be able to do so.

@nedrichards
Copy link
Member

bot, build org.jitsi.jitsi-meet

@flathubbot
Copy link

Queued test build for org.jitsi.jitsi-meet.

@flathubbot
Copy link

Started test build 24738

@flathubbot
Copy link

Build 24738 failed

@nedrichards
Copy link
Member

Appdata screenshot didn't download, but otherwise it's all good!

• url-not-found : failed to download (HTTP 500: Internal Server Error) [https://gitcdn.link/repo/jitsi/jitsi-meet-electron/master/screenshot.png]

Now stealing the play store description, also changed the screenshot link
@nedrichards
Copy link
Member

bot, build org.jitsi.jitsi-meet

@flathubbot
Copy link

Queued test build for org.jitsi.jitsi-meet.

@flathubbot
Copy link

Started test build 24744

@flathubbot
Copy link

Build 24744 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/23784/org.jitsi.jitsi-meet.flatpakref

- unappimage jitsi-meet-x86_64.AppImage
- rm jitsi-meet-x86_64.AppImage

- sed -e 's/Exec=.*/Exec=jitsi-meet-run/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use desktop-file-edit here btw

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think desktop-file-edit can change the Exec key though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can change the value of any key I think

Copy link
Author

@ananace ananace Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can change the value of any extended key (X-*), but for default keys there are only setters for Name, GenericName, Comment, and Icon. (As well as list adders/removers for categories, mime-types, and only show in environments)

So no, it can't change Exec - at least the version that's available in org.freedesktop.Sdk.

Edit: Or actually, it's not erroring anymore on non-extended keys, guess that one's been patched. It was screaming loudly at me before when I tried to do just that...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desktop-file-edit --set-key=Exec --set-value=something $desktop-file works just fine here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not able to recreate the exact error anymore here either, but the application shouted at me when I tried before. Maybe I managed to get an input error?

@bilelmoussaoui
Copy link
Member

bot, build org.jitsi.jitsi-meet

@flathubbot
Copy link

Queued test build for org.jitsi.jitsi-meet.

@flathubbot
Copy link

Started test build 24748

@flathubbot
Copy link

Build 24748 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/23788/org.jitsi.jitsi-meet.flatpakref

@nedrichards
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this has been created: https://github.com/flathub/org.jitsi.jitsi-meet

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Aug 4, 2020
@ananace ananace deleted the org.jitsi.jitsi-meet branch August 4, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants