New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.jitsi.jitsi-meet #1690
Add org.jitsi.jitsi-meet #1690
Conversation
bot, build org.jitsi.jitsi-meet |
Queued test build for org.jitsi.jitsi-meet. |
Started test build 24738 |
Build 24738 failed |
Appdata screenshot didn't download, but otherwise it's all good!
|
Now stealing the play store description, also changed the screenshot link
bot, build org.jitsi.jitsi-meet |
Queued test build for org.jitsi.jitsi-meet. |
Started test build 24744 |
Build 24744 successful
|
org.jitsi.jitsi-meet.yaml
Outdated
- unappimage jitsi-meet-x86_64.AppImage | ||
- rm jitsi-meet-x86_64.AppImage | ||
|
||
- sed -e 's/Exec=.*/Exec=jitsi-meet-run/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use desktop-file-edit here btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think desktop-file-edit
can change the Exec
key though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can change the value of any key I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can change the value of any extended key (X-*
), but for default keys there are only setters for Name, GenericName, Comment, and Icon. (As well as list adders/removers for categories, mime-types, and only show in environments)
So no, it can't change Exec
- at least the version that's available in org.freedesktop.Sdk.
Edit: Or actually, it's not erroring anymore on non-extended keys, guess that one's been patched. It was screaming loudly at me before when I tried to do just that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desktop-file-edit --set-key=Exec --set-value=something $desktop-file
works just fine here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not able to recreate the exact error anymore here either, but the application shouted at me when I tried before. Maybe I managed to get an input error?
bot, build org.jitsi.jitsi-meet |
Queued test build for org.jitsi.jitsi-meet. |
Started test build 24748 |
Build 24748 successful
|
/merge |
A repository for this has been created: https://github.com/flathub/org.jitsi.jitsi-meet You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
Upstream has been asked about Flatpak support [1][2], but are currently not willing to spend their own limited time on setting up and maintaining a second Linux build pipeline (understandably seeing the lack of Flatpak support in electron-builder), so I've here written up a manifest that uses unappimage to repackage their existing AppImage build into a Flatpak.
That way, people who want to use Jitsi Meet's desktop app without manually handling their AppImage will still be able to do so.