Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.lbry.lbry-app #175

Closed
wants to merge 1 commit into from

Conversation

julianrichen
Copy link

@julianrichen julianrichen commented Dec 6, 2017

LBRY is a free, open, and community-run digital marketplace for multimedia.
Site: https://lbry.io/
Source: https://github.com/lbryio/lbry


This pr adds the LBRY client via a deb file. I tried building from source with node/npm/yarn but like other flathub users mentioned, it was overly complicated.

Should OARS tags be added to the appdata file and if so how? Content on LBRY is created by users so it can contain any of the content warnings found in OARS.

What isn't subject to the content are these settings found in the app:

  • "Share Diagnostic Data" is enabled by default
  • "Show NSFW content" is disabled by default

Maybe OARS needs a new tag like social-content with None, Regulated, Unregulated? This might be better discussed on the the OARS bugtracker (if they have one).

@nedrichards
Copy link
Member

bot, build io.lbry.lbry-app

@nedrichards
Copy link
Member

We're fine with Electron apps coming as extra-data binaries for now, so long as there's an understanding that - when the tools are ready - we'll transition them over to properly built apps.

Love the questions about OARS - I totally agree that we should look to make this easier to cover user generated content apps like this. I don't know that there's a specific bugtracker to discuss that, although I'll ping @hughsie to be aware.

@hughsie
Copy link

hughsie commented Dec 6, 2017

@nedrichards there's no OARS bugtracker per-se, I'll work on something today.

@hughsie
Copy link

hughsie commented Dec 6, 2017

@nedrichards here you go: https://github.com/hughsie/oars -- I've asked @jimmac to look at the styling and UX today as i agree it's not the most beautiful thing to use and he might have some ideas.

@julianrichen
Copy link
Author

Thanks for taking a look into the OARS question. I guess we can wait to add them until OARS is ready to support more general applications?

Build was also successful :)
https://flathub.org/builds/#/builders/4/builds/1206

@nedrichards
Copy link
Member

Yep, happy to wait on that.

@nedrichards
Copy link
Member

Repository has been created: https://github.com/flathub/io.lbry.lbry-app

@nedrichards nedrichards closed this Dec 6, 2017
@hughsie
Copy link

hughsie commented Dec 6, 2017

Would https://hughsie.github.io/oars/ be good enough?

@julianrichen
Copy link
Author

See hughsie/oars#1 for more about general OARS options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants