Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.mightycreak.Diffuse #1961

Closed
wants to merge 1 commit into from
Closed

Add io.github.mightycreak.Diffuse #1961

wants to merge 1 commit into from

Conversation

MightyCreak
Copy link

No description provided.

@bilelmoussaoui
Copy link
Member

bot, build com.github.mightycreak.Diffuse

@flathubbot
Copy link

Queued test build for com.github.mightycreak.Diffuse.

@bilelmoussaoui bilelmoussaoui changed the title Add manifest for com.github.mightycreak.Diffuse Add com.github.mightycreak.Diffuse Nov 29, 2020
@flathubbot
Copy link

Started test build 33430

@flathubbot
Copy link

Build 33430 failed

@barthalion
Copy link
Member

Your app needs to install appdata and desktop files. You can use https://bilelmoussaoui.github.io/metainfo-generator/ or https://www.freedesktop.org/software/appstream/metainfocreator/#/ for the first.

@MightyCreak
Copy link
Author

FYI I haven't forgotten, I just wait for the weekend to start on it again 😉

@MightyCreak
Copy link
Author

I got a question about the app ID, most of the application I see have upper case letters in their ID (mostly for the app name, e.g. com.github.bilelmoussaoui.Authenticator), but the appstreamcli validate warns about using upper case letters.

What should I do? follow the validation warning or what appears to be the de facto standard?

Thanks!

@MightyCreak
Copy link
Author

MightyCreak commented Dec 5, 2020

In the meantime, I've added a metainfo file in the repo and pushed the manifest with the latest commit. Hope it'll work this time 😉

Edit: Also I changed the app-id to io.github.mightycreak.Diffuse (as advised by freedesktop).

@MightyCreak MightyCreak changed the title Add com.github.mightycreak.Diffuse Add io.github.mightycreak.Diffuse Dec 5, 2020
@MightyCreak
Copy link
Author

bot, build io.github.mightycreak.Diffuse

@flathubbot
Copy link

Queued test build for io.github.mightycreak.Diffuse.

@flathubbot
Copy link

Started test build 33929

@flathubbot
Copy link

Build 33929 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/32685/io.github.mightycreak.Diffuse.flatpakref

@barthalion
Copy link
Member

I got a question about the app ID, most of the application I see have upper case letters in their ID (mostly for the app name, e.g. com.github.bilelmoussaoui.Authenticator), but the appstreamcli validate warns about using upper case letters.

It's totally fine; also it doesn't complain on our infrastructure. Maybe some old version?

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this has been created: https://github.com/flathub/io.github.mightycreak.Diffuse

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants