Add org.kde.kdenlive #205
Add org.kde.kdenlive #205
Conversation
|
I'm not an expert, but is there a reason why this doesn't have some of the dependencies of the version in Flatpak KDE Apps? https://github.com/KDE/flatpak-kde-applications/blob/master/org.kde.kdenlive.json @aleixpol @grulja as our local KDE community and Flatpak experts I'd appreciate your thoughts on this if you have time. |
org.kde.kdenlive.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "kdecoration", |
There was a problem hiding this comment.
Who uses kdecoration? If it's generically required it should possibly go to the Sdk.
There was a problem hiding this comment.
It was needed for building oxygen.
org.kde.kdenlive.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "oxygen", |
AFAIU, it does, it just has many others additionally. |
|
@aleixpol you're right, I wasn't looking closely enough - however I'm glad we got you onto the review anyway! |
|
bot, build org.kde.kdenlive |
| ] | ||
| }, | ||
| { | ||
| "name": "x265", |
There was a problem hiding this comment.
In order to build on arm and aarch64 you're going to need to replicate the fixes here: flathub/org.pitivi.Pitivi@548615c
| ] | ||
| }, | ||
| { | ||
| "name": "libsamplerate", |
There was a problem hiding this comment.
In order to fix this on aarch64 you'll need to rm-configure: true and autoreconf e.g. https://github.com/flathub/shared-modules/blob/9cc549960171590d6a0736d762c083a51d1c5779/udev/udev-175.json
| ], | ||
| "modules": [ | ||
| { | ||
| "name": "gtk2", |
There was a problem hiding this comment.
It's needed by a MLT module:
https://github.com/mltframework/mlt/tree/master/src/modules/gtk2
|
bot, build org.kde.kdenlive |
| ] | ||
| }, | ||
| { | ||
| "name": "gavl", |
There was a problem hiding this comment.
this needs the autoreconf dance as well. There also seems to be a slightly different compile error here for ARM
There was a problem hiding this comment.
Ah, I remember now - I saw the same issue in Pitivi which also uses gavl. It's something to do with libm. If you can work out how to fix it, all the better! If not, then it's OK to use a flathub.json file to ban the arm architecture for now.
|
bot, build org.kde.kdenlive |
|
with the flathub.json arm won't be built, however I'm happy to work on that in a PR after we merge this edit: I can't read commit logs. |
|
Repository has been created: https://github.com/flathub/org.kde.kdenlive |
No description provided.