Add Go SDK extension #213
Add Go SDK extension #213
Conversation
|
bot, build org.freedesktop.Sdk.Extension.golang |
|
If we want this available at runtime for apps you're going to need an install.sh to call as well, like the JDK: https://github.com/flathub/org.freedesktop.Sdk.Extension.openjdk9/blob/master/org.freedesktop.Sdk.Extension.openjdk9.json#L168 |
|
Hm, no opinion about making it installable, I'm fine either way. |
| "only-arches": [ | ||
| "arm" | ||
| ], | ||
| "url": "https://dl.google.com/go/go1.9.2.linux-armv6l.tar.gz", |
There was a problem hiding this comment.
I'm pretty sure this is the wrong arm architecture for our definition of ARM. We should test, but we may have to ban arm from this extension
There was a problem hiding this comment.
Ah, right, we're targetting armv7? I could probably make some workaround to build it from source, I'll take a look at it.
There was a problem hiding this comment.
If we can just build it from source that would be nice in general.
There was a problem hiding this comment.
After another look, seems to be potential time sink. Last release that doesn't require working Go compiler is 1.4 and it doesn't seem to build on my Odroid C2 (aarch64).
One option would be another extension to build this one (that would also cut some time for building), but use binary release just for aarch64.
There was a problem hiding this comment.
Yeah - I'd rather have go, and the bootstrap is super messy.
There was a problem hiding this comment.
@ramcq which exact arm do we use again? you were the last person who touched that as I remember ;-)
There was a problem hiding this comment.
Looking at how gcc is built, it's armv7-a. Fix will come in a minute…
There was a problem hiding this comment.
My bad, there are no binaries optimized for armv7. I will test armv6 one on my Odroid XU4 and merge it as is if it works properly.
|
bot, build org.freedesktop.Sdk.Extension.golang |
Fixes #210