Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.ultimaker.cura #2773

Closed
wants to merge 5 commits into from
Closed

Add com.ultimaker.cura #2773

wants to merge 5 commits into from

Conversation

Tim453
Copy link

@Tim453 Tim453 commented Jan 15, 2022

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: Please add your app as a flatpak Ultimaker/Cura#6027 (comment)
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (All patches are related to the flatpak build-process)

com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

bot, build com.ultimaker.cura

@flathubbot
Copy link

Queued test build for com.ultimaker.cura.

@flathubbot
Copy link

Started test build 74893

@flathubbot
Copy link

Build 74893 failed

@hfiguiere
Copy link
Contributor

build fails because the appdata fail to validate:

builddir/files/share/appdata/com.ultimaker.cura.appdata.xml: FAILED:
• tag-missing           : <content_rating> required [use https://odrs.gnome.org/oars]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://raw.githubusercontent.com/Ultimaker/Cura/master/screenshot.png]
• tag-missing           : <release> required
Validation of files failed

Co-authored-by: Hubert Figuière <hub@figuiere.net>
@nedrichards
Copy link
Member

bot, build com.ultimaker.cura

you can use this command yourself as well when making changes

@flathubbot
Copy link

Queued test build for com.ultimaker.cura.

@flathubbot
Copy link

Started test build 74927

@hfiguiere
Copy link
Contributor

Still needs appdata patches to not fail though

com.ultimaker.cura.yml Outdated Show resolved Hide resolved
@flathubbot
Copy link

Build 74927 failed

@hfiguiere
Copy link
Contributor

I may have been excessive in what should be removed this time. :-/

Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally

com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

hfiguiere commented Jan 16, 2022

My local build works but I had to disable Wayland. It seems that there are bugs with Wayland, works fine with X11.

com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
com.ultimaker.cura.yml Outdated Show resolved Hide resolved
@Tim453
Copy link
Author

Tim453 commented Jan 16, 2022

bot, build com.ultimaker.cura

@flathubbot
Copy link

Queued test build for com.ultimaker.cura.

@flathubbot
Copy link

Started test build 74990

@flathubbot
Copy link

Build 74990 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72839/com.ultimaker.cura.flatpakref

@barthalion
Copy link
Member

Hey @Ghostkeeper, I understand your stance of supporting only a single package for your app, but would you be interested in having write access to the Flathub repo? Just in case you would like to merge some PRs or close issues.

@Ghostkeeper
Copy link

You could add me as having write access if you like. But indeed I can't promise that I'll do anything with it.

If you/someone asks for help I'd be happy to lend my expertise though, and if it's easier to make a PR or close the issue then I'd use those permissions to do that.

So in short, I have no interest in spending time to maintain this. But I have good intentions and willingness to help with small things ;)

@barthalion
Copy link
Member

/merge @Ghostkeeper

That's absolutely fine. Cheers :)

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/com.ultimaker.cura

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants