Add manifest for org.kde.kdf

[flyingcakes85]

Please confirm your submission meets all the criteria

• I have read the App Requirements and App Maintenance pages.
• My pull request follows the instructions at App Submission.
• I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
• All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
• I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
• I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
• Any additional patches or files have been submitted to the upstream projects concerned.
  • dolphin.appdata.patch : https://invent.kde.org/system/dolphin/-/merge_requests/325 Not relevant after 21616ca
  • kdf.appdata.patch : https://invent.kde.org/utilities/kdf/-/merge_requests/3

---

Notes Dolphin manifest borrowed from https://github.com/flathub/org.kde.dolphin

Not relevant now.

[flyingcakes85]

bot, build org.kde.kdf

[flathubbot]

Queued test build for org.kde.kdf.

[flathubbot]

Started test build 75179

[flyingcakes85]

Dolphin (and its dependencies) removed from manifest.

[flyingcakes85]

bot, build org.kde.kdf

[flathubbot]

Queued test build for org.kde.kdf.

[flathubbot]

Build 75179 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73031/org.kde.kdf.flatpakref

[flathubbot]

Started test build 75182

[flathubbot]

Build 75182 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73034/org.kde.kdf.flatpakref

[nedrichards]

@flathub/kde FYI

I wonder about the open in file manager stuff. Without a call to flatpak-spawn (and the necessary permission) it's not going to work that well, but also doing it seamlessly would ideally require some changes in the main codebase. What does the rest of the KDE team think?

[tsdgeos]

My opinion is that we need to patch kdf to disable the feature of letting you chose a random file manager when running in flatpak and instead just a QDesktopServices::openUrl call

[flyingcakes85]

My opinion is that we need to patch kdf to disable the feature of letting you chose a random file manager when running in flatpak and instead just a QDesktopServices::openUrl call

I'll take care of KDF source code, and update this pull request with a patch. Till then this PR is on hold.

[travier]

CC @flathub/kde

[flyingcakes85]

bot, build org.kde.kdf

[flathubbot]

Queued test build for org.kde.kdf.

[flathubbot]

Started test build 76314

[flathubbot]

Build 76314 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74185/org.kde.kdf.flatpakref

[flyingcakes85]

@travier

Opening in file manager still doesn't work on my machines. The only scenario where I can get it to work is when having Thunar as default file manager and opening a thumb drive. Opening internal drives don't work. And with Dolhpin, nothing opens.

Could someone please test the build from flathubbot in last comment? Install it, and from KDF, right click -> open in file manager; and check if it opens.

[nedrichards]

Absolutely does not work on Fedora Silverblue 35 under GNOME.

[tsdgeos]

Seems you have found a bug in Qt's portal integration, looping @grulja in

We're doing QDesktopServices::openUrl("file:///"), i.e. open the root folder, but Qt is xdgDesktopPortalOpenFile, trying to open a fd out of / and passing it to the portal OpenFile method

It is my understanding the portal OpenDirectory method would make more sense in this case

[travier]

Tested this one and it looks like it needs --device=all to figure out the names and mount points, etc.
Apart from that, it worked for me so LGTM. If it does not work well for others then let's merge it as Beta and figure things out progressively?

[tsdgeos]

going to beta seems reasonable to me

[flyingcakes85]

bot, build org.kde.kdf

[flathubbot]

Queued test build for org.kde.kdf.

[flathubbot]

Started test build 76861

[flathubbot]

Build 76861 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74733/org.kde.kdf.flatpakref

[grulja]

Seems you have found a bug in Qt's portal integration, looping @grulja in

We're doing QDesktopServices::openUrl("file:///"), i.e. open the root folder, but Qt is xdgDesktopPortalOpenFile, trying to open a fd out of / and passing it to the portal OpenFile method

It is my understanding the portal OpenDirectory method would make more sense in this case

Yes and I think back then when I implemented this method didn't exist. I can try to look into this once I find some time or if anyone wants to do it, I will happily help.

It needs to just check here [1] that the URL is a directory and make a different call.

[1] - https://invent.kde.org/qt/qt/qtbase/-/blob/dev/src/gui/platform/unix/qgenericunixservices.cpp#L301

[travier]

I think we should merge this one as Beta as it works. We will fix the remaining issues as we go.

[travier]

CC @flathub/kde

[tsdgeos]

makes sense

[barthalion]

/merge:beta

[flathubbot]

A repository for this submission has been created: https://github.com/flathub/org.kde.kdf

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!