Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest for org.kde.krdc #2859

Closed
wants to merge 5 commits into from

Conversation

flyingcakes85
Copy link

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

Signed-off-by: Snehit Sah <snehitsah@protonmail.com>
@flyingcakes85
Copy link
Author

bot, build org.kde.krdc

@flathubbot
Copy link

Queued test build for org.kde.krdc.

@flyingcakes85
Copy link
Author

@travier

I have tested VNC to work 👍 Couldn't get RDP to work, which is probably because of my inexperience with the Windows environment.

Also, should we need pulseaudio sandbox permission here? I don't get any error messages in terminal when using VNC, but I believe RDP also carries audio.

@flathubbot
Copy link

Started test build 78989

@flathubbot
Copy link

Build 78989 failed

Signed-off-by: Snehit Sah <snehitsah@protonmail.com>
@flyingcakes85
Copy link
Author

bot, build org.kde.krdc

@flathubbot
Copy link

Queued test build for org.kde.krdc.

org.kde.krdc.json Outdated Show resolved Hide resolved
],
"modules": [
{
"name": "libusb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should get it from shared-modules.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated 👍

org.kde.krdc.json Outdated Show resolved Hide resolved
Signed-off-by: Snehit Sah <snehitsah@protonmail.com>
Signed-off-by: Snehit Sah <snehitsah@protonmail.com>
@flyingcakes85
Copy link
Author

bot, build org.kde.krdc

@flathubbot
Copy link

Queued test build for org.kde.krdc.

@travier
Copy link
Member

travier commented Feb 19, 2022

CC @flathub/kde

@travier
Copy link
Member

travier commented Feb 19, 2022

Pulseaudio should be fine

@travier
Copy link
Member

travier commented Feb 19, 2022

Not yet tested but LGTM

@flathubbot
Copy link

Started test build 79018

@flathubbot
Copy link

Build 79018 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76892/org.kde.krdc.flatpakref

Signed-off-by: Snehit Sah <snehitsah@protonmail.com>
@flyingcakes85
Copy link
Author

bot, build org.kde.krdc

@flathubbot
Copy link

Queued test build for org.kde.krdc.

@flathubbot
Copy link

Started test build 79081

@flathubbot
Copy link

Build 79081 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/76956/org.kde.krdc.flatpakref

@flyingcakes85
Copy link
Author

Added pulseaudio permission.

@nedrichards
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.kde.krdc

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants