New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.photoqt.PhotoQt #292

Closed
wants to merge 5 commits into
base: new-pr
from

Conversation

4 participants
@luspi

luspi commented Mar 5, 2018

PhotoQt is a different kind of image viewer. Website: https://photoqt.org

@@ -0,0 +1,40 @@
{
"id": "org.qt.photoqt",

This comment has been minimized.

@TingPing

TingPing Mar 5, 2018

Member

org.photoqt.PhotoQt

"rename-desktop-file": "photoqt.desktop",
"rename-appdata-file": "photoqt.appdata.xml",
"rename-icon": "photoqt",
"finish-args": ["--share=ipc","--socket=x11","--socket=wayland","--filesystem=host","--device=dri","--socket=pulseaudio"],

This comment has been minimized.

@TingPing

TingPing Mar 5, 2018

Member

Please put these on their own line. Same applies for everything else and broken whitespace throughout.

"modules": [
{
"name": "exiv2",
"cmake": true,

This comment has been minimized.

@TingPing

TingPing Mar 5, 2018

Member

Use "buildsystem": "cmake-ninja",. Same for the other.

},
{
"name": "libraw",
"cmake": false,

This comment has been minimized.

@TingPing

TingPing Mar 5, 2018

Member

That is the default, can be removed. Same for the other.

@TingPing

This comment has been minimized.

Member

TingPing commented Mar 5, 2018

@TingPing TingPing changed the title from Add PhotoQt to Flathub to Add org.photoqt.PhotoQt Mar 5, 2018

"--share=ipc",
"--socket=x11",
"--socket=wayland",
"--filesystem=host",

This comment has been minimized.

@nedrichards

nedrichards Mar 6, 2018

Member

this seems like too broad a privilege request

This comment has been minimized.

@Sesivany

Sesivany Mar 6, 2018

Hi, I'm the one who updated manifest to be Flathub ready. I'm not sure PhotoQt can work in full sandbox via portal, so there needs to be direct access to the filesystem. Access only to home would be fine? The original manifest had "host" and I thought the app author wanted it to browse outside home as well, so I kept it there.

This comment has been minimized.

@nedrichards

nedrichards Mar 6, 2018

Member

@luspi what's the expected use case here? xdg-pictures and videos? home? viewing random assets from the rest of the system?

This comment has been minimized.

@luspi

luspi Mar 6, 2018

I think "viewing random assets" is a pretty good description of its use has. It includes of course folders like xdg-pictures and home, but also goes beyond that to anywhere a use might encounter an image of some type...

@nedrichards

This comment has been minimized.

Member

nedrichards commented Mar 6, 2018

The JSON file needs to be the same as the app-id and org.qt.photoqt.json isn't org.photoqt.PhotoQt so the build fails https://flathub.org/builds/#/builders/76/builds/21

@nedrichards

This comment has been minimized.

Member

nedrichards commented Mar 6, 2018

bot, build org.photoqt.PhotoQt

@nedrichards

This comment has been minimized.

Member

nedrichards commented Mar 6, 2018

Looks like there's something wrong in the section of the appdata:

Error loading AppData file: failed to parse /app/share/appdata/org.photoqt.PhotoQt.appdata.xml: Error on line 81 char 6: already set '​' and tried to replace with '

https://flathub.org/builds/#/builders/4/builds/2195 e.g.

Other than that, everything looks like it built perfectly.

@Sesivany

This comment has been minimized.

Sesivany commented Mar 6, 2018

I copied that section from a different file and it has probably introduced some non-visible characters that shouldn't be there. When I removed all the spaces, the file gets validated. I also noted that if doesn't have any nested elements, which it doesn't in this case because I didn't include download/installed sizes, it can self-close. So that part can be simplified into this:

<releases>
<release version="1.6" date="2018-02-20" />
</releases>
@luspi

This comment has been minimized.

luspi commented Mar 6, 2018

Simplified release section, and found the "faulty" spaces in the appdata file. It should (hopefully) work now!

@nedrichards

This comment has been minimized.

Member

nedrichards commented Mar 7, 2018

bot, build org.photoqt.PhotoQt

@nedrichards

This comment has been minimized.

Member

nedrichards commented Mar 8, 2018

Repository has been created: https://github.com/flathub/org.photoqt.PhotoQt

@nedrichards nedrichards closed this Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment