Add org.photoqt.PhotoQt #292
Conversation
org.qt.photoqt.json
Outdated
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "id": "org.qt.photoqt", | |||
org.qt.photoqt.json
Outdated
| "rename-desktop-file": "photoqt.desktop", | ||
| "rename-appdata-file": "photoqt.appdata.xml", | ||
| "rename-icon": "photoqt", | ||
| "finish-args": ["--share=ipc","--socket=x11","--socket=wayland","--filesystem=host","--device=dri","--socket=pulseaudio"], |
There was a problem hiding this comment.
Please put these on their own line. Same applies for everything else and broken whitespace throughout.
org.qt.photoqt.json
Outdated
| "modules": [ | ||
| { | ||
| "name": "exiv2", | ||
| "cmake": true, |
There was a problem hiding this comment.
Use "buildsystem": "cmake-ninja",. Same for the other.
org.qt.photoqt.json
Outdated
| }, | ||
| { | ||
| "name": "libraw", | ||
| "cmake": false, |
There was a problem hiding this comment.
That is the default, can be removed. Same for the other.
|
bot, build org.photoqt.PhotoQt |
org.qt.photoqt.json
Outdated
| "--share=ipc", | ||
| "--socket=x11", | ||
| "--socket=wayland", | ||
| "--filesystem=host", |
There was a problem hiding this comment.
this seems like too broad a privilege request
There was a problem hiding this comment.
Hi, I'm the one who updated manifest to be Flathub ready. I'm not sure PhotoQt can work in full sandbox via portal, so there needs to be direct access to the filesystem. Access only to home would be fine? The original manifest had "host" and I thought the app author wanted it to browse outside home as well, so I kept it there.
There was a problem hiding this comment.
@luspi what's the expected use case here? xdg-pictures and videos? home? viewing random assets from the rest of the system?
There was a problem hiding this comment.
I think "viewing random assets" is a pretty good description of its use has. It includes of course folders like xdg-pictures and home, but also goes beyond that to anywhere a use might encounter an image of some type...
|
The JSON file needs to be the same as the app-id and org.qt.photoqt.json isn't org.photoqt.PhotoQt so the build fails https://flathub.org/builds/#/builders/76/builds/21 |
|
bot, build org.photoqt.PhotoQt |
|
Looks like there's something wrong in the section of the appdata:
https://flathub.org/builds/#/builders/4/builds/2195 e.g. Other than that, everything looks like it built perfectly. |
|
I copied that section from a different file and it has probably introduced some non-visible characters that shouldn't be there. When I removed all the spaces, the file gets validated. I also noted that if doesn't have any nested elements, which it doesn't in this case because I didn't include download/installed sizes, it can self-close. So that part can be simplified into this: |
|
Simplified release section, and found the "faulty" spaces in the appdata file. It should (hopefully) work now! |
|
bot, build org.photoqt.PhotoQt |
|
Repository has been created: https://github.com/flathub/org.photoqt.PhotoQt |
PhotoQt is a different kind of image viewer. Website: https://photoqt.org