-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifest for io.github.jacalz.rymdport #2971
Conversation
bot, build io.github.jacalz.rymdport |
Queued test build for io.github.jacalz.rymdport. |
Started test build 84435 |
Build 84435 failed |
bot, build io.github.jacalz.rymdport |
Queued test build for io.github.jacalz.rymdport. |
Started test build 84497 |
Sorry for the failures last time. I have corrected the metadata and it should hopefully work now :) |
Build 84497 successful
|
I got this error on Fedora Workstation 36 Beta. I don't know what that's about. It is a beta after all, so I guess it might not matter much. Didn't get it on the installation in the screenshot above.
|
Something really strange is happening with the screenshots.I don't know if this has anything to do witch the fact that it hasn't been pushed to flathub yet but it is certainly strange. EDIT: Might be something that is expected. Seems to be broken when installing #2972 as well. |
You can ignore this error. |
It doesn't work properlyt for locally install package. You can safely ignore. |
# Support only the most common directories. | ||
- --filesystem=xdg-desktop | ||
- --filesystem=xdg-documents | ||
- --filesystem=xdg-download | ||
- --filesystem=xdg-music | ||
- --filesystem=xdg-pictures | ||
- --filesystem=xdg-videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to use --filesystem=home
here, but it's up to you. Ideally it should use filesystem portal (e.g. GtkNativeFileChooser does that by default for GTK apps) but I don't know if it's possible to achieve with some Go library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I might switch that over to —filesystem=home
then. What I have now works but it prints an error every time the file viewer is opened.
I would want to get the portals working through Dbus (or CGO by linking to the C-library but I want try and avoid that) but there isn’t a lot of information or examples out there (especially for Dbus).
/merge |
A repository for this submission has been created: https://github.com/flathub/io.github.jacalz.rymdport You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
Is there a timeframe for when it will be available on flathub.org? I get an error when I try to go to it using the link in the repository details. |
There was a long publishing queue today, but it should be visible now. |
This solves Jacalz/rymdport#23. I have tried to slim down the filesystem access as much as possible but it is hard given that the idea with the application is to send files. An option would be to make some paths read only, I guess. I'm happy for suggestions on how the permissions should be set to make the most sense.
Please confirm your submission meets all the criteria