Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest for io.github.jacalz.rymdport #2971

Closed
wants to merge 2 commits into from
Closed

Add manifest for io.github.jacalz.rymdport #2971

wants to merge 2 commits into from

Conversation

Jacalz
Copy link

@Jacalz Jacalz commented Apr 1, 2022

This solves Jacalz/rymdport#23. I have tried to slim down the filesystem access as much as possible but it is hard given that the idea with the application is to send files. An option would be to make some paths read only, I guess. I'm happy for suggestions on how the permissions should be set to make the most sense.

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@hfiguiere
Copy link
Contributor

bot, build io.github.jacalz.rymdport

@flathubbot
Copy link

Queued test build for io.github.jacalz.rymdport.

@flathubbot
Copy link

Started test build 84435

@flathubbot
Copy link

Build 84435 failed

@Jacalz
Copy link
Author

Jacalz commented Apr 2, 2022

bot, build io.github.jacalz.rymdport

@flathubbot
Copy link

Queued test build for io.github.jacalz.rymdport.

@flathubbot
Copy link

Started test build 84497

@Jacalz
Copy link
Author

Jacalz commented Apr 2, 2022

Sorry for the failures last time. I have corrected the metadata and it should hopefully work now :)

@flathubbot
Copy link

Build 84497 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82358/io.github.jacalz.rymdport.flatpakref

@Jacalz
Copy link
Author

Jacalz commented Apr 2, 2022

It is working as expected on both KDE Plasma and Gnome using Fedora 35.
image

@Jacalz
Copy link
Author

Jacalz commented Apr 2, 2022

I got this error on Fedora Workstation 36 Beta. I don't know what that's about. It is a beta after all, so I guess it might not matter much. Didn't get it on the installation in the screenshot above.

Warning: Not exporting file io.github.jacalz.rymdport.appdata.xml of unsupported type.

@Jacalz
Copy link
Author

Jacalz commented Apr 2, 2022

Something really strange is happening with the screenshots.I don't know if this has anything to do witch the fact that it hasn't been pushed to flathub yet but it is certainly strange.
image

EDIT: Might be something that is expected. Seems to be broken when installing #2972 as well.

@hfiguiere
Copy link
Contributor

I got this error on Fedora Workstation 36 Beta. I don't know what that's about. It is a beta after all, so I guess it might not matter much. Didn't get it on the installation in the screenshot above.

Warning: Not exporting file io.github.jacalz.rymdport.appdata.xml of unsupported type.

You can ignore this error.

@hfiguiere
Copy link
Contributor

Something really strange is happening with the screenshots.I don't know if this has anything to do witch the fact that it hasn't been pushed to flathub yet but it is certainly strange.

It doesn't work properlyt for locally install package. You can safely ignore.

Comment on lines +22 to +28
# Support only the most common directories.
- --filesystem=xdg-desktop
- --filesystem=xdg-documents
- --filesystem=xdg-download
- --filesystem=xdg-music
- --filesystem=xdg-pictures
- --filesystem=xdg-videos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to use --filesystem=home here, but it's up to you. Ideally it should use filesystem portal (e.g. GtkNativeFileChooser does that by default for GTK apps) but I don't know if it's possible to achieve with some Go library.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I might switch that over to —filesystem=home then. What I have now works but it prints an error every time the file viewer is opened.

I would want to get the portals working through Dbus (or CGO by linking to the C-library but I want try and avoid that) but there isn’t a lot of information or examples out there (especially for Dbus).

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/io.github.jacalz.rymdport

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Apr 4, 2022
@Jacalz Jacalz deleted the io.github.jacalz.rymdport branch April 4, 2022 09:44
@Jacalz
Copy link
Author

Jacalz commented Apr 4, 2022

Is there a timeframe for when it will be available on flathub.org? I get an error when I try to go to it using the link in the repository details.

@barthalion
Copy link
Member

There was a long publishing queue today, but it should be visible now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants