Add com.github._0negal.Viper

[GeckoEidechse]

Please confirm your submission meets all the criteria

• I have read the App Requirements and App Maintenance pages.
• My pull request follows the instructions at App Submission.
• I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  Non-standard permissions:
  • --filesystem=host: I'd love to restrict this further but the point of this application is to autodetect the Steam install location of the game "Titanfall 2" and then access that location.
    In order to do that it needs access to Steam configuration file that specifies the install locations which can be located at multiple places inside the user's home directory depending on the install method (deb vs Flatpak). Further it then needs access to the game's install location which can be anywhere in the filesystem.
  • --filesystem=home: Required to access the Steam library location config file (read-only) as well as the installed "Titanfall 2" game itself (write access to download and add the mod).
  • --filesystem=/media: Alternative install location for games on Steam if they are installed on a SD card. Common on platforms like the SteamDeck.
  • --filesystem=/mnt: Alternative install location for games on Steam if they are installed a secondary drive (like an HDD due to storage limitations on the main drive.
• All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
• I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub.
  Link: feat: Flatpak support 0neGal/viper#75 (comment)
• I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  There's a small issue with this part:
  I cannot make the application ID 1:1 based on the repo URL as the owner's name starts with a zero, so the resulting ID would be com.github.0neGal.viper. However having an element in the ID start with a digit is disallowed by Flatpak. As such, when discussing with the maintainer we settled on com.github.onegal.Viper. Checking Github, there exists no user with the name onegal so I guess this should be fine ¯\_(ツ)_/¯
  AppID updated to com.github._0negal.Viper
• Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

[hfiguiere]

:-(

[GeckoEidechse]

What's the issue here exactly? As explained in the initial description--filesystem=host is sadly necessary :/

[hfiguiere]

bot, build com.github.onegal.viper

[flathubbot]

Queued test build for com.github.onegal.viper.

[hfiguiere]

bot, build com.github.onegal.Viper

[flathubbot]

Queued test build for com.github.onegal.Viper.

[hfiguiere]

bot, build com.github._0negal.Viper

[flathubbot]

Queued test build for com.github._0negal.Viper.

[GeckoEidechse]

Also I forgot to mention but if accepted, @0neGal should probably also be given write access to the repo ^^

[flathubbot]

Started test build 85162

[flathubbot]

Build 85162 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83007/com.github._0negal.Viper.flatpakref

[barthalion]

--filesystem=host: I'd love to restrict this further but the point of this application is to autodetect the Steam install location of the game "Titanfall 2" and then access that location.
In order to do that it needs access to Steam configuration file that specifies the install locations which can be located at multiple places inside the user's home directory depending on the install method (deb vs Flatpak). Further it then needs access to the game's install location which can be anywhere in the filesystem.

Please bear with me for a minute… If we're talking about installations done by host-level Steam or flatpaked Steam, wouldn't this location be the same in 99% of cases? The point of my question is that we generally prefer locked-down permissions that are good enough for the majority of users over wide ones, as they can always be modified through CLI or Flatseal.

[GeckoEidechse]

--filesystem=host: I'd love to restrict this further but the point of this application is to autodetect the Steam install location of the game "Titanfall 2" and then access that location.
In order to do that it needs access to Steam configuration file that specifies the install locations which can be located at multiple places inside the user's home directory depending on the install method (deb vs Flatpak). Further it then needs access to the game's install location which can be anywhere in the filesystem.

Please bear with me for a minute… If we're talking about installations done by host-level Steam or flatpaked Steam, wouldn't this location be the same in 99% of cases? The point of my question is that we generally prefer locked-down permissions that are good enough for the majority of users over wide ones, as they can always be modified through CLI or Flatseal.

I agree, I'd also prefer more locked down permissions but the issue is the following:

So the location of the Steam library config file is known and is always within the user's home directory in one of 3 places:

• ~/.steam/steam/steamapps/libraryfolders.vdf
• ~/.var/app/com.valvesoftware.Steam/.steam/steam/steamapps/libraryfolders.vdf
• ~/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/libraryfolders.vdf

The default install location for the game itself is usually also within the user's home directory (depending on how Steam was installed):

• ~/.steam/steam/steamapps/common/
• ~/.var/app/com.valvesoftware.Steam/.steam/steam/steamapps/common/
• ~/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/

However that's just the default location. For example one of our targets with Viper is the SteamDeck where the game it adds the mods for could be installed on the SD card. So we also need file system access to that location (usually /media?).

There's also users that have games installed on a secondary drive (usually some HDD) due to games' ever increasing filesize. As such to make the install as smooth as possible for those users, /mnt access would probably also be needed as well.

Then finally, to my knowledge, on Linux a user can add arbitrary locations in the filesystem as a Steam library folder which is where things start to break down if we limit ourselves to just home directory, /mnt and /media.

Now I agree with your reasoning that 99% of users will either have their install in either of those 3 ($HOME, /media, /mnt), so I can try to update the manifest accordingly. However this means we'll also have to add some documentation somewhere for the last 1% of users to tell them how to enable full access via Flatseal.

[GeckoEidechse]

I restricted file system access now in 8cc035d

[GeckoEidechse]

bot, build com.github._0negal.Viper

[flathubbot]

Queued test build for com.github._0negal.Viper.

[flathubbot]

Started test build 85208

[flathubbot]

Build 85208 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83053/com.github._0negal.Viper.flatpakref

[GeckoEidechse]

Newest build seems to still work ^^

[barthalion]

/merge @0neGal

[flathubbot]

A repository for this submission has been created: https://github.com/flathub/com.github._0negal.Viper

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!