Add org.freedesktop.Sdk.Extension.wxwidgets

[tinywrkb]

Please confirm your submission meets all the criteria

• I have read the App Requirements and App Maintenance pages.
• My pull request follows the instructions at App Submission.
• I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
• All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
• I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: Flatpak SDK extension wxWidgets/wxWidgets#22370
• I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
• Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

This SDK extension packages wxWidgets, WebKitGTK, and their dependencies.
I'm not developing wxWidgets apps, but a while back I took over the maintenance of Codeblocks IDE (I was nostalgic), which its maintainer and original submitter was MIA.
As a wxWidgets app, an important feature of Codeblocks is its support for wxWidgets development, and the previous Flatpak maintainer did not take this into consideration.

When I started maintaining the app, I quickly switched the runtime to Gnome due to the availability WebKitGTK, and bundled wxWidgets' development files (headers, pkgconfig, ...) to have some sort of wxWidgets development environment, but I don't think this is the way forward.
Instead, I'm proposing adding a wxWidgets Freedesktop SDK extension which could work with any IDE.

Relevant Codeblocks app changes flathub/org.codeblocks.codeblocks#21

This is still WIP, so it's marked as draft.

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 88712

[flathubbot]

Build 88712 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86529/org.freedesktop.Sdk.Extension.wxwidgets.flatpakref

[tinywrkb]

Per wxWidgets' developer recommendation, I switch to wxWidgets 3.1.x development releases, and will switch back to stable after the 3.2.0 release will be out.

What's blocking this now is mainly doing more testing. Done
I might revise the deployment script, install.sh, though that much lower priority, and might be done post merge. Done

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 88826

[flathubbot]

Build 88826 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86642/org.freedesktop.Sdk.Extension.wxwidgets.flatpakref

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 88903

[flathubbot]

Build 88903 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86721/org.freedesktop.Sdk.Extension.wxwidgets.flatpakref

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 89235

[flathubbot]

Build 89235 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87043/org.freedesktop.Sdk.Extension.wxwidgets.flatpakref

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 89249

[tinywrkb]

This should be ready now.
I went through all the code samples of wxWidgets, and they can be built and run correctly as far as I can tell.
Also built and run with this extension the Flathub app net.sourceforge.GrandOrgue, and Codeblock (svn trunk version).

[tinywrkb]

Last push just renames the examples.

[tinywrkb]

Hence the reason for wondering if maybe it would be better to place it in a separate sdk extension.

No, there's no way to keep these extensions in sync and not break ABI without manual intervention of a Flathub admin keeping ostree refs from being published until both extensions are rebuilt. We will be going to need a separate Flatpak branch for each WebKitGTK release that breaks ABI, and after it's published to update wxWidgets to use the new WebKitGTK branch. I asked similar question about handling cross-Flatpak-ref ABI dependency here.

After considering this again, I see that WebKitGTK has semi-annual schedule for major releases, so maybe if we're not strict as the Freedesktop runtime about adding new symbols, and don't mind stating that we can't promise that downgrading the WebKitGTK extension won't break ABI of code linked against the latest WebKitGTK build, then I guess a WebKitGTK extension is achievable without too much trouble.
We will need 2 branches for each runtime version, so a total of 4 maintained branches, and maybe retire some of them earlier than the runtime.
I'm not sure yet what the best way to wire-up ABI checks of minor releases, or should we just trust upstream.

[tinywrkb]

Hence the reason for wondering if maybe it would be better to place it in a separate sdk extension.

No, there's no way to keep these extensions in sync and not break ABI without manual intervention of a Flathub admin keeping ostree refs from being published until both extensions are rebuilt. We will be going to need a separate Flatpak branch for each WebKitGTK release that breaks ABI, and after it's published to update wxWidgets to use the new WebKitGTK branch. I asked similar question about handling cross-Flatpak-ref ABI dependency here.

After considering this again, I see that WebKitGTK has semi-annual schedule for major releases, so maybe if we're not strict as the Freedesktop runtime about adding new symbols, and don't mind stating that we can't promise that downgrading the WebKitGTK extension won't break ABI of code linked against the latest WebKitGTK build, then I guess a WebKitGTK extension is achievable without too much trouble. We will need 2 branches for each runtime version, so a total of 4 maintained branches, and maybe retire some of them earlier than the runtime. I'm not sure yet what the best way to wire-up ABI checks of minor releases, or should we just trust upstream.

I take this back. I've been criticized for doing something similar in an extension. Avoiding ABI breaking by setting a branch version.
I'm not going to bother with this when no official Flathub guidelines document how to avoid ABI breakage between different Flatpak refs/packages.
This is a Flatpak limitation that should be fixed, and I won't try to work around.

I have no further changes planned to this PR, and it's ready to be merged.

[4c0n]

Hence the reason for wondering if maybe it would be better to place it in a separate sdk extension.

No, there's no way to keep these extensions in sync and not break ABI without manual intervention of a Flathub admin keeping ostree refs from being published until both extensions are rebuilt. We will be going to need a separate Flatpak branch for each WebKitGTK release that breaks ABI, and after it's published to update wxWidgets to use the new WebKitGTK branch. I asked similar question about handling cross-Flatpak-ref ABI dependency here.

After considering this again, I see that WebKitGTK has semi-annual schedule for major releases, so maybe if we're not strict as the Freedesktop runtime about adding new symbols, and don't mind stating that we can't promise that downgrading the WebKitGTK extension won't break ABI of code linked against the latest WebKitGTK build, then I guess a WebKitGTK extension is achievable without too much trouble. We will need 2 branches for each runtime version, so a total of 4 maintained branches, and maybe retire some of them earlier than the runtime. I'm not sure yet what the best way to wire-up ABI checks of minor releases, or should we just trust upstream.

I take this back. I've been criticized for doing something similar in an extension. Avoiding ABI breaking by setting a branch version.
I'm not going to bother with this when no official Flathub guidelines document how to avoid ABI breakage between different Flatpak refs/packages.
This is a Flatpak limitation that should be fixed, and I won't try to work around.

I have no further changes planned to this PR, and it's ready to be merged.

Totally agree that it would be great to have more guidelines and information on this subject.
Too bad communication seems difficult when it comes to matters like this, I recently tried proposing for more guidelines on the discourse forum, but also did not get any useful response so far.
I truly hope communication will improve for Flathub and its community.

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 99256

[flathubbot]

Build 99256 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/96984/org.freedesktop.Sdk.Extension.wxwidgets.flatpakref

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 100012

[flathubbot]

Build 100012 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97742/org.freedesktop.Sdk.Extension.wxwidgets.flatpakref

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 109310

[flathubbot]

Build 109310 failed

[tinywrkb]

bot, build org.freedesktop.Sdk.Extension.wxwidgets

[flathubbot]

Queued test build for org.freedesktop.Sdk.Extension.wxwidgets.

[flathubbot]

Started test build 111363

[flathubbot]

Build 111363 failed

[flathubbot]

This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins