Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KBibTeX #3152

Closed
wants to merge 1 commit into from
Closed

Add KBibTeX #3152

wants to merge 1 commit into from

Conversation

Mailaender
Copy link

@Mailaender Mailaender commented May 15, 2022

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: https://bugs.kde.org/show_bug.cgi?id=453850
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.) https://invent.kde.org/office/kbibtex/-/merge_requests/16

@Mailaender
Copy link
Author

bot, build org.kde.kbibtex

@flathubbot
Copy link

Queued test build for org.kde.kbibtex.

@flathubbot
Copy link

Started test build 91620

@flathubbot
Copy link

Build 91620 failed

@Mailaender
Copy link
Author

bot, build org.kde.kbibtex

@flathubbot
Copy link

Queued test build for org.kde.kbibtex.

@flathubbot
Copy link

Started test build 91623

org.kde.kbibtex.json Outdated Show resolved Hide resolved
org.kde.kbibtex.json Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

cc @flathub/kde

org.kde.kbibtex.json Outdated Show resolved Hide resolved
org.kde.kbibtex.json Outdated Show resolved Hide resolved
@tsdgeos
Copy link

tsdgeos commented May 15, 2022

The metadata patch has been posted to the wrong place

@Mailaender
Copy link
Author

GitHub was not configured correctly. It didn't show up as a mirror.

@tsdgeos
Copy link

tsdgeos commented May 15, 2022

GitHub was not configured correctly. It didn't show up as a mirror.

That's not something you can configure as far as I know, but i'll be happy to learn otherwise if you have some pointers.

@flathubbot
Copy link

Build 91623 failed

@Mailaender
Copy link
Author

I thought I saw the Linux kernel as a read-only mirror in @github once, but I also don't find a way to turn off pull requests. As your @GitLab instance is essentially the same as GitHub, why even keep this trap?

@Mailaender
Copy link
Author

bot, build org.kde.kbibtex

@flathubbot
Copy link

Queued test build for org.kde.kbibtex.

@flathubbot
Copy link

Started test build 91636

@flathubbot
Copy link

Build 91636 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/89378/org.kde.kbibtex.flatpakref

@tsdgeos
Copy link

tsdgeos commented May 15, 2022

I thought I saw the Linux kernel as a read-only mirror in @github once, but I also don't find a way to turn off pull requests. As your @GitLab instance is essentially the same as GitHub, why even keep this trap?

There's several extensive discussions about it in the KDE mailing lists, I don't think I can provide a simple summary.

@barthalion
Copy link
Member

@tsdgeos Other than the appdata patch being submitted to wrong place, all good from your perspective?

org.kde.kbibtex.json Outdated Show resolved Hide resolved
org.kde.kbibtex.json Outdated Show resolved Hide resolved
org.kde.kbibtex.json Outdated Show resolved Hide resolved
org.kde.kbibtex.json Outdated Show resolved Hide resolved
@travier
Copy link
Member

travier commented May 16, 2022

I thought I saw the Linux kernel as a read-only mirror in @github once, but I also don't find a way to turn off pull requests. As your @GitLab instance is essentially the same as GitHub, why even keep this trap?

KDE development happens on its own GitLab instance. Please file PRs there. GitHub is only a mirror.

@Mailaender
Copy link
Author

I already did that. See the updated first post.

@Mailaender
Copy link
Author

bot, build org.kde.kbibtex

@flathubbot
Copy link

Queued test build for org.kde.kbibtex.

@tsdgeos
Copy link

tsdgeos commented May 16, 2022

@tsdgeos Other than the appdata patch being submitted to wrong place, all good from your perspective?

Not an expert on kbibtext but if it works, seems reasonable

@flathubbot
Copy link

Started test build 91811

@flathubbot
Copy link

Build 91811 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/89551/org.kde.kbibtex.flatpakref

@cho2
Copy link
Member

cho2 commented May 17, 2022

Looks good

Cuplikan layar dari 2022-05-17 13-51-13

@travier
Copy link
Member

travier commented May 17, 2022

Still 2 minor issues in comments above.

@Mailaender
Copy link
Author

@tsdgeos See https://github.com/GStreamer/gst-plugins-ugly for a mirrored repository that is indicated as such.

@Mailaender
Copy link
Author

bot, build org.kde.kbibtex

@flathubbot
Copy link

Queued test build for org.kde.kbibtex.

@flathubbot
Copy link

Started test build 92630

@flathubbot
Copy link

Build 92630 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90359/org.kde.kbibtex.flatpakref

@travier
Copy link
Member

travier commented May 21, 2022

LGTM

@travier
Copy link
Member

travier commented May 21, 2022

Great work pushing all the missing KDE Apps here!

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.kde.kbibtex

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this May 23, 2022
@Mailaender Mailaender deleted the kbibtex branch May 23, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants