Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KSirK #3188

Closed
wants to merge 1 commit into from
Closed

Add KSirK #3188

wants to merge 1 commit into from

Conversation

Mailaender
Copy link

@Mailaender Mailaender commented May 22, 2022

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: https://invent.kde.org/games/ksirk/-/issues/1
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.) https://invent.kde.org/games/ksirk/-/merge_requests/6

@Mailaender
Copy link
Author

Mailaender commented May 22, 2022

bot, build org.kde.ksirk

@flathubbot
Copy link

Queued test build for org.kde.ksirk.

2 similar comments
@flathubbot
Copy link

Queued test build for org.kde.ksirk.

@flathubbot
Copy link

Queued test build for org.kde.ksirk.

@flathubbot
Copy link

Started test build 92704

@flathubbot
Copy link

Build 92704 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/90433/org.kde.ksirk.flatpakref

@hfiguiere
Copy link
Contributor

cc @flathub/kde

@CarlSchwan
Copy link
Member

Looks good to me and I merged https://invent.kde.org/games/ksirk/-/merge_requests/6

@@ -0,0 +1,49 @@
From fe6d6ac54134ed80be121952893bf4aaa29995a8 Mon Sep 17 00:00:00 2001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe merge the two patches? Probably not that important since the patch won't be required in the future

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep the commit log readable.

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.kde.ksirk

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this May 23, 2022
@Mailaender Mailaender deleted the ksirk branch May 23, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants