-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dragon Player #3228
Add Dragon Player #3228
Conversation
Note: the file selection does not open, drag and drop however works → beta channel candidate. |
bot, build org.kde.dragonplayer |
Queued test build for org.kde.dragonplayer. |
cc @flathub/kde |
Started test build 94196 |
Build 94196 successful
|
The open file dialog doesn't show up ^_^ |
Yeah, I think not being able to open files the obvious way is a blocker for now. |
I noticed that opening a file via Dolphin already works, so I submitted it. |
This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins |
I suggest to put it in beta. |
maybe¿ what others think @travier ? |
Dragon has changed quite a bit since this PR was opened; can you rebase with 23.04.1 and try again, maybe? It's possible the issue with opening files from the app as gone away already. |
bot, build org.kde.dragonplayer |
Queued test build for org.kde.dragonplayer. |
Started test build 45652 |
Seems it is indeed already fixed. |
Build 45652 successful
|
Indeed, fixed for me too. |
+1 from me |
I have
and unrelated to above, I wasn't able to play video files :/ |
Worked fine on KDE Neon using X11. |
bot, build org.kde.dragonplayer |
Queued test build for org.kde.dragonplayer. |
Started test build 45771 |
Build 45771 successful
|
Looks reasonably good to me |
OK, it does play some video files. Let's do it. |
Ping @barthalion @nedrichards Please reopen. |
bot, build org.kde.dragonplayer |
Queued test build for org.kde.dragonplayer. |
Started test build 49244 |
Build 49244 successful
|
bot, build org.kde.dragonplayer |
Queued test build for org.kde.dragonplayer. |
Started test build 49391 |
Build 49391 successful
|
Unfortunately Dragon Player does not correctly use the portals right now so this does not work thus why it needs full home access. |
bot, build org.kde.dragonplayer |
Queued test build for org.kde.dragonplayer. |
Started test build 49625 |
Build 49625 successful
|
Hum, this crashed for me in the open dialog. I have the following in the console but I don't think that's the issue:
Looks like this still needs more fixes 😕. |
Seems fine on my end with the latest build. |
The |
Please confirm your submission meets all the criteria