Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dragon Player #3228

Closed
wants to merge 2 commits into from
Closed

Add Dragon Player #3228

wants to merge 2 commits into from

Conversation

Mailaender
Copy link

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: https://matrix.to/#/#flatpak:kde.org
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.) https://invent.kde.org/multimedia/dragon/-/merge_requests/3

@Mailaender
Copy link
Author

Note: the file selection does not open, drag and drop however works → beta channel candidate.

@Mailaender
Copy link
Author

bot, build org.kde.dragonplayer

@flathubbot
Copy link

Queued test build for org.kde.dragonplayer.

@hfiguiere
Copy link
Contributor

cc @flathub/kde

@flathubbot
Copy link

Started test build 94196

@flathubbot
Copy link

Build 94196 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/91925/org.kde.dragonplayer.flatpakref

@tsdgeos
Copy link

tsdgeos commented Jun 1, 2022

The open file dialog doesn't show up ^_^

@nedrichards
Copy link
Member

Yeah, I think not being able to open files the obvious way is a blocker for now.

@Mailaender
Copy link
Author

I noticed that opening a file via Dolphin already works, so I submitted it.

@flathubbot
Copy link

This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins

@flathubbot flathubbot added the Stale Stale PR, no activity for over a year label Jun 6, 2023
@Mailaender
Copy link
Author

I suggest to put it in beta.

@tsdgeos
Copy link

tsdgeos commented Jun 6, 2023

maybe¿ what others think @travier ?

@Pointedstick
Copy link
Member

Dragon has changed quite a bit since this PR was opened; can you rebase with 23.04.1 and try again, maybe? It's possible the issue with opening files from the app as gone away already.

@Mailaender
Copy link
Author

bot, build org.kde.dragonplayer

@flathubbot
Copy link

Queued test build for org.kde.dragonplayer.

@flathubbot
Copy link

Started test build 45652

@Mailaender
Copy link
Author

Seems it is indeed already fixed.

@flathubbot
Copy link

Build 45652 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28272/org.kde.dragonplayer.flatpakref

@Pointedstick
Copy link
Member

Indeed, fixed for me too.

@Pointedstick
Copy link
Member

+1 from me

@travier
Copy link
Member

travier commented Jun 7, 2023

I have

kf.solid.backends.udisks2: Failed enumerating UDisks2 objects: "org.freedesktop.DBus.Error.Disconnected" 
 "Not connected to D-Bus server"
kf.solid.backends.udisks2: Failed enumerating UDisks2 objects: "org.freedesktop.DBus.Error.Disconnected" 
 "Not connected to D-Bus server"

and unrelated to above, I wasn't able to play video files :/

@Mailaender
Copy link
Author

Worked fine on KDE Neon using X11.

@Mailaender
Copy link
Author

bot, build org.kde.dragonplayer

@flathubbot
Copy link

Queued test build for org.kde.dragonplayer.

@flathubbot
Copy link

Started test build 45771

@flathubbot
Copy link

Build 45771 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28391/org.kde.dragonplayer.flatpakref

@tsdgeos
Copy link

tsdgeos commented Jun 7, 2023

Looks reasonably good to me

@travier
Copy link
Member

travier commented Jun 8, 2023

OK, it does play some video files. Let's do it.

@travier
Copy link
Member

travier commented Jun 8, 2023

CC @barthalion @nedrichards

@flathubbot flathubbot closed this Jun 23, 2023
@Mailaender
Copy link
Author

Ping @barthalion @nedrichards Please reopen.

org.kde.dragonplayer.json Show resolved Hide resolved
org.kde.dragonplayer.json Outdated Show resolved Hide resolved
@travier
Copy link
Member

travier commented Jun 23, 2023

bot, build org.kde.dragonplayer

@flathubbot
Copy link

Queued test build for org.kde.dragonplayer.

@flathubbot
Copy link

Started test build 49244

@flathubbot
Copy link

Build 49244 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/31843/org.kde.dragonplayer.flatpakref

@Mailaender
Copy link
Author

bot, build org.kde.dragonplayer

@flathubbot
Copy link

Queued test build for org.kde.dragonplayer.

@flathubbot
Copy link

Started test build 49391

@flathubbot
Copy link

Build 49391 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/31989/org.kde.dragonplayer.flatpakref

@travier
Copy link
Member

travier commented Jun 26, 2023

Unfortunately Dragon Player does not correctly use the portals right now so this does not work thus why it needs full home access.

@barthalion
Copy link
Member

bot, build org.kde.dragonplayer

@flathubbot
Copy link

Queued test build for org.kde.dragonplayer.

@flathubbot
Copy link

Started test build 49625

@flathubbot
Copy link

Build 49625 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/32228/org.kde.dragonplayer.flatpakref

@travier
Copy link
Member

travier commented Jun 26, 2023

Hum, this crashed for me in the open dialog. I have the following in the console but I don't think that's the issue:

kf.kio.widgets: Cannot read information about filesystem under path "/var/home/tim/.var/app/org.kde.dragonplayer/cache/thumbnails/"
kf.solid.frontend.devicemanager: Couldn't get StorageAccess for ""/var/home/tim/.var/app/org.kde.dragonplayer/cache/thumbnails/"" - File doesn't exist

Looks like this still needs more fixes 😕.

@barthalion
Copy link
Member

Seems fine on my end with the latest build.

@Erick555
Copy link

The /media and /run/media paths that were part of original manifest are missing.

@flathubbot flathubbot closed this Jul 11, 2023
@Mailaender Mailaender deleted the dragonplayer branch July 13, 2023 09:28
@Justinzobel Justinzobel mentioned this pull request Oct 23, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale PR, no activity for over a year
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants