Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2009scape Launcher #3640

Closed
wants to merge 17 commits into from
Closed

Add 2009scape Launcher #3640

wants to merge 17 commits into from

Conversation

dginovker
Copy link

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@dginovker
Copy link
Author

bot, build org._2009scape.Launcher

@flathubbot
Copy link

Queued test build for org._2009scape.Launcher.

@flathubbot
Copy link

Started test build 6364

@flathubbot
Copy link

Build 6364 failed

@dginovker
Copy link
Author

bot, build org._2009scape.Launcher

@flathubbot
Copy link

Queued test build for org._2009scape.Launcher.

@flathubbot
Copy link

Started test build 6365

@flathubbot
Copy link

Build 6365 failed

@dginovker
Copy link
Author

bot, build org._2009scape.Launcher

@flathubbot
Copy link

Queued test build for org._2009scape.Launcher.

@flathubbot
Copy link

Started test build 6367

@flathubbot
Copy link

Build 6367 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/118825/org._2009scape.Launcher.flatpakref

@dginovker
Copy link
Author

App works as expected

org._2009scape.Launcher.json Outdated Show resolved Hide resolved
org._2009scape.Launcher.json Outdated Show resolved Hide resolved
},
{
"type": "file",
"url": "https://gitlab.com/2009scape/Saradomin-Launcher/-/jobs/artifacts/master/raw/Saradomin/2009scape-launcher-sc?job=pack_linux_sc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the other should NOT point to master but rather to a specific revision.

also this seems to be DOTnet based, but I don't see a runtime installed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Dotnet based, but it has all the dependencies included (so it works). There's a non-dependency included version, I'll see if I can get that one working with the Flatpak runtime 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably doing something wrong but I wasn't able to get the non-dependency version working with either the Mono or Dotnet extension :/. In any case, this Flatpak works on a brand new Fedora Silverblue install so it seems to be fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you are packaging an x86_64 binary on aarch64.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some quick research, and it seems like you can't natively run x86_64 binaries on aarch64. I'll exclude aarch64

dginovker and others added 3 commits November 13, 2022 17:11
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Co-authored-by: Hubert Figuière <hub@figuiere.net>
@dginovker
Copy link
Author

bot, build org._2009scape.Launcher

@flathubbot
Copy link

Queued test build for org._2009scape.Launcher.

@flathubbot
Copy link

Started test build 6497

@flathubbot
Copy link

Build 6497 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/118953/org._2009scape.Launcher.flatpakref

@dginovker
Copy link
Author

Looks good - Ready for another review 👍

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org._2009scape.Launcher

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Nov 13, 2022
@dginovker
Copy link
Author

Thanks for all your help @hfiguiere ❤️ 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants