New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2009scape Launcher #3640
Add 2009scape Launcher #3640
Conversation
…redownload everything every time
… org._2009scape.Launcher.appdata.xml from upstream
…o work out of the box
bot, build org._2009scape.Launcher |
Queued test build for org._2009scape.Launcher. |
Started test build 6364 |
Build 6364 failed |
bot, build org._2009scape.Launcher |
Queued test build for org._2009scape.Launcher. |
Started test build 6365 |
Build 6365 failed |
bot, build org._2009scape.Launcher |
Queued test build for org._2009scape.Launcher. |
Started test build 6367 |
Build 6367 successful
|
App works as expected |
org._2009scape.Launcher.json
Outdated
}, | ||
{ | ||
"type": "file", | ||
"url": "https://gitlab.com/2009scape/Saradomin-Launcher/-/jobs/artifacts/master/raw/Saradomin/2009scape-launcher-sc?job=pack_linux_sc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and the other should NOT point to master
but rather to a specific revision.
also this seems to be DOTnet based, but I don't see a runtime installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Dotnet based, but it has all the dependencies included (so it works). There's a non-dependency included version, I'll see if I can get that one working with the Flatpak runtime 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm probably doing something wrong but I wasn't able to get the non-dependency version working with either the Mono or Dotnet extension :/. In any case, this Flatpak works on a brand new Fedora Silverblue install so it seems to be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you are packaging an x86_64 binary on aarch64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some quick research, and it seems like you can't natively run x86_64 binaries on aarch64. I'll exclude aarch64
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Co-authored-by: Hubert Figuière <hub@figuiere.net>
bot, build org._2009scape.Launcher |
Queued test build for org._2009scape.Launcher. |
Started test build 6497 |
Build 6497 successful
|
Looks good - Ready for another review 👍 |
/merge |
A repository for this submission has been created: https://github.com/flathub/org._2009scape.Launcher You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you have never maintained an application before, common questions are answered in the app maintenance guide. Thanks! |
Thanks for all your help @hfiguiere ❤️ 🌮 |
Please confirm your submission meets all the criteria