add io.github.rocket.editor

[kusma]

Please confirm your submission meets all the criteria

• I have read the App Requirements and App Maintenance pages.
• My pull request follows the instructions at App Submission.
• I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
• All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
• I am an upstream contributor to the project.
• I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
• Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

[JakobDev]

You should upstream the AppStream, the Desktop Entry and the Icon.

[JakobDev]

bot, build io.github.rocket.editor

[flathubbot]

Queued test build for io.github.rocket.editor.

[flathubbot]

Started test build 24634

[flathubbot]

Build 24634 failed

[kusma]

Error: Command 'editor' not found

Hmm, that's what I got when I didn't patch the install target. With that patch, it works fine locally. I wonder what's going on...

[kusma]

You should upstream the AppStream, the Desktop Entry and the Icon

Yes, I intend to. The upstream project isn't in a great state right now, with our CI being broken. I'm working on that right now.

[kusma]

Error: Command 'editor' not found

Hmm, that's what I got when I didn't patch the install target. With that patch, it works fine locally. I wonder what's going on...

Just tried again, and I can't reproduce it. Anyone able to trigger another build and see if it still happens?

[kusma]

It's really strange.

make: Nothing to be done for 'install'.

This seems to indicate that the patching didn't work; there's nothing in the install target.

But I see the patching work:

Applying patch 0001-install-editor.patch
FB: Running: git apply -v -p1 /srv/buildbot/worker/build-x86_64-2/build/0001-install-editor.patch
Checking patch editor/editor.pro...
Applied patch editor/editor.pro cleanly.

I'm really lost as to what's going wrong here...

[hfiguiere]

You can trigger yourself, FYI

[hfiguiere]

the previous failed build say make: Nothing to be done for 'install'.

You can still install it in the post-install. That should be enough.

[kusma]

bot, build io.github.rocket.editor

[flathubbot]

Queued test build for io.github.rocket.editor.

[flathubbot]

Started test build 24649

[kusma]

@hfiguiere: Yeah, that's a fair point. Maybe that's a bit less error-prone in the first place.

[flathubbot]

Build 24649 failed

[hfiguiere]

also is it supposed to play sounds? I see no permission for it if that's the case.

[kusma]

also is it supposed to play sounds? I see no permission for it if that's the case.

No, it doesn't play sound by itself. That's up to the "remote end", which is connected over a socket, and something that I don't control.

[kusma]

bot, build io.github.rocket.editor

[flathubbot]

Queued test build for io.github.rocket.editor.

[flathubbot]

Started test build 24650

[kusma]

bot, build io.github.rocket.editor

[flathubbot]

Queued test build for io.github.rocket.editor.

[flathubbot]

Build 24650 failed

[flathubbot]

Started test build 24651

[flathubbot]

Build 24651 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/7298/io.github.rocket.editor.flatpakref

[kusma]

OK, seems close. The built version works fine here, but: the screenshot doesn't load for me any more. It did before, so I'm not quite sure what's up with that. Is this maybe some optimization for non-production builds that's expected?

[kusma]

With the local build, the screenshot works fine...

[kusma]

Tested the aarch64 build as well, and it seems to work just fine!

[barthalion]

/merge

[flathubbot]

A repository for this submission has been created: https://github.com/flathub/io.github.rocket.editor

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!