-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.dbgate.DbGate #3955
Add org.dbgate.DbGate #3955
Conversation
You should create a working package before opening a request here... |
manifest.json
Outdated
"id": "org.dbgate.DbGate", | ||
"command": "electron-wrapper", | ||
"runtime": "org.freedesktop.Platform", | ||
"runtime-version": "20.08", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this runtime is EOL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to 22.08, thanks
Sorry, I followed and probably misunderstood instructions here https://github.com/flathub/flathub/wiki/App-Submission Should I simply commit flatpak package into this pull request? |
I just mean update this PR with a fully functioning manifest. Calling it a draft for now is good. |
you don't even tell how to build your package. When it said "Add your app’s manifest to the branch, commit it and push the commit" it mean just that. It implies the manifest is working. |
This manifest is working, I built the flatpak single-file bundle using it (more exactly it is output of electron flatpak builder). I didn't know anything about flatpak, so I supposed it will work similarily as snap. But I see I must study it a bit more deeply. |
I pushed updated manifest, now building flatpak from manifest works, but there is still problem in bundled app, when bundling with flatpak |
- --share=network | ||
- --socket=x11 | ||
# allow fork subprocess | ||
- --socket=system-bus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to specify a dbus name here system-bus
is not allowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what is causing the build failure.
bot, build org.dbgate.DbGate |
Queued test build for org.dbgate.DbGate. |
Started test build 27821 |
Build 27821 failed |
Ref #5240 for new PR BTW |
Please confirm your submission meets all the criteria