Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.dbgate.DbGate #3955

Closed
wants to merge 3 commits into from
Closed

Add org.dbgate.DbGate #3955

wants to merge 3 commits into from

Conversation

janproch
Copy link

@janproch janproch commented Mar 5, 2023

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@TingPing TingPing changed the title manifest file Add org.dbgate.DbGate Mar 5, 2023
@TingPing
Copy link
Member

TingPing commented Mar 5, 2023

You should create a working package before opening a request here...

manifest.json Outdated
"id": "org.dbgate.DbGate",
"command": "electron-wrapper",
"runtime": "org.freedesktop.Platform",
"runtime-version": "20.08",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this runtime is EOL.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 22.08, thanks

@janproch janproch marked this pull request as draft March 6, 2023 07:48
@janproch
Copy link
Author

janproch commented Mar 6, 2023

You should create a working package before opening a request here...

Sorry, I followed and probably misunderstood instructions here https://github.com/flathub/flathub/wiki/App-Submission

Should I simply commit flatpak package into this pull request?

@TingPing
Copy link
Member

TingPing commented Mar 6, 2023

Should I simply commit flatpak package into this pull request?

I just mean update this PR with a fully functioning manifest.

Calling it a draft for now is good.

@hfiguiere
Copy link
Contributor

You should create a working package before opening a request here...

Sorry, I followed and probably misunderstood instructions here https://github.com/flathub/flathub/wiki/App-Submission

you don't even tell how to build your package. When it said "Add your app’s manifest to the branch, commit it and push the commit" it mean just that. It implies the manifest is working.

@janproch
Copy link
Author

janproch commented Mar 6, 2023

This manifest is working, I built the flatpak single-file bundle using it (more exactly it is output of electron flatpak builder). I didn't know anything about flatpak, so I supposed it will work similarily as snap. But I see I must study it a bit more deeply.

@janproch
Copy link
Author

I pushed updated manifest, now building flatpak from manifest works, but there is still problem in bundled app, when bundling with flatpak

- --share=network
- --socket=x11
# allow fork subprocess
- --socket=system-bus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to specify a dbus name here system-bus is not allowed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what is causing the build failure.

@hfiguiere
Copy link
Contributor

bot, build org.dbgate.DbGate

@flathubbot
Copy link

Queued test build for org.dbgate.DbGate.

@flathubbot
Copy link

Started test build 27821

@flathubbot
Copy link

Build 27821 failed

@hfiguiere hfiguiere added the awaiting-changes Pull request waiting for changes from author label Aug 9, 2023
@bbhtt bbhtt added the work-in-progress Draft PRs label Feb 13, 2024
@dbgate dbgate closed this by deleting the head repository May 10, 2024
@rugk
Copy link

rugk commented May 14, 2024

Ref #5240 for new PR BTW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Pull request waiting for changes from author work-in-progress Draft PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants