Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eu.cichy1173.tabela #4412

Closed
wants to merge 11 commits into from
Closed

Add eu.cichy1173.tabela #4412

wants to merge 11 commits into from

Conversation

cichy1173
Copy link

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project.
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

hfiguiere
hfiguiere reviewed Aug 11, 2023
View reviewed changes
eu.cichy1173.tabela.yml Outdated Show resolved Hide resolved
hfiguiere
hfiguiere requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please try to build locally at least once.

@hfiguiere
Copy link
Contributor

bot, build eu.cichy1173.tabela

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Started test build 58384

@flathubbot
Copy link

Build 58384 failed

hfiguiere
hfiguiere reviewed Aug 12, 2023
View reviewed changes
eu.cichy1173.tabela.yml Outdated
- --socket=x11
- --device=dri
- --filesystem=host
desktop-file-name: eu.cichy1173.eu.desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(flatpak-builder:2): flatpak-builder-WARNING **: 13:01:38.950: Unknown property desktop-file-name for type BuilderManifest

hfiguiere
hfiguiere reviewed Aug 12, 2023
View reviewed changes
eu.cichy1173.tabela.yml Outdated
- type: git
url: https://codeberg.org/cichy1173/tabela-flatpak.git
commit: 73753ba98060e0b8f792f306e36eafbe941b6b55
build-extensions:
Copy link
Contributor

@hfiguiere hfiguiere Aug 12, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(flatpak-builder:2): flatpak-builder-WARNING **: 13:01:38.950: Unknown property build-extensions for type BuilderModule

hfiguiere
hfiguiere reviewed Aug 12, 2023
View reviewed changes
eu.cichy1173.tabela.yml Outdated
commit: 73753ba98060e0b8f792f306e36eafbe941b6b55
build-extensions:
- org.freedesktop.Sdk.Extension.python3.9
extra-data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(flatpak-builder:2): flatpak-builder-WARNING **: 13:01:38.950: Unknown property extra-data for type BuilderModule

hfiguiere
hfiguiere requested changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These there error message are why I asked if you tried to build locally. Obviously you ignored them.

Also ou need to add the python dependencies for the build to work.

See for tools that can help
https://github.com/flatpak/flatpak-builder-tools/tree/master/pip

@cichy1173
Copy link
Author

These there error message are why I asked if you tried to build locally. Obviously you ignored them.

Sorry, I managed to build on this manifest once. It is possible that it was a bug or some bug in GNOME Builder. Local build is now working.

Thanks for your work and sorry for the faulty PR. I am new to this.

@hfiguiere
Copy link
Contributor

bot, build eu.cichy1173.tabela

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Started test build 58417

@flathubbot
Copy link

Build 58417 failed

@hfiguiere
Copy link
Contributor

The mandatory appstream file is not found. I don't see one being installed.

@hfiguiere
Copy link
Contributor

Nor is an icon or a desktop file.

@cichy1173
Copy link
Author

bot, build eu.cichy1173.tabela

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Started test build 58458

@flathubbot
Copy link

Build 58458 failed

@cichy1173
Copy link
Author

bot, build eu.cichy1173.tabela

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Started test build 58473

@flathubbot
Copy link

Build 58473 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41102/eu.cichy1173.tabela.flatpakref

hfiguiere
hfiguiere reviewed Aug 12, 2023
View reviewed changes
eu.cichy1173.tabela.yml Outdated
- --share=network
- --socket=x11
- --device=dri
- --filesystem=host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a very wide filesystem permission.

Why is it necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. It is to much wide. I changed it for home and I removed network.

I think, home is the best choice. Why? Main goal of the app is opening users csv files for displaying content in table, and also adding new rows and saving in xml or csv.

@cichy1173
Copy link
Author

bot, build eu.cichy1173.tabela

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Started test build 58526

@flathubbot
Copy link

Build 58526 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41158/eu.cichy1173.tabela.flatpakref

travier
travier reviewed Aug 14, 2023
View reviewed changes
.gitignore Outdated
Comment on lines 1 to 4

.flatpak-builder/

build-dir/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.flatpak-builder/
build-dir/
.flatpak-builder/
build-dir/

eu.cichy1173.tabela.yml Outdated
command: tabela
finish-args:
- --share=ipc
- --socket=x11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --socket=x11
- --socket=wayland
- --socket=fallback-x11

@cichy1173
Copy link
Author

bot, build eu.cichy1173.tabela

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Started test build 58733

@flathubbot
Copy link

Build 58733 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41366/eu.cichy1173.tabela.flatpakref

@cichy1173
Copy link
Author

Build 58733 successful
To test this build, install it from the testing repository:

Works fine

@travier
Copy link
Member

travier commented Aug 14, 2023 •
edited

This application should be able to use the file desktop portal to get files from the user home dir instead of relying on static access to all files.

I don't know why this does not work.

@cichy1173
Copy link
Author

This application should be able to use the file desktop portal to get files from the user home dir instead of relying on static access to all files.

I don't know why this does not work.

I use standard QFileDialog.getOpenFileName from PySide6

@hfiguiere
Copy link
Contributor

We could restrict filesystem to xdg-documents

@cichy1173
Copy link
Author

We could restrict filesystem to xdg-documents

I will test this solution locally. If it works fine, I will send new commit.

@cichy1173
Copy link
Author

bot, build eu.cichy1173.tabela

@flathubbot
Copy link

Queued test build for eu.cichy1173.tabela.

@flathubbot
Copy link

Started test build 59512

@flathubbot
Copy link

Build 59512 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42153/eu.cichy1173.tabela.flatpakref

@hfiguiere
Copy link
Contributor

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/eu.cichy1173.tabela

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier left review comments

@hfiguiere hfiguiere hfiguiere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cichy1173 @hfiguiere @flathubbot @travier