Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.bktus.gpgfrontend #4608

Closed
wants to merge 2 commits into from
Closed

Conversation

saturneric
Copy link

@saturneric saturneric commented Oct 15, 2023

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

com.bktus.gpgfrontend.desktop Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.metainfo.xml Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.metainfo.xml Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.metainfo.xml Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
- --share=ipc
- --socket=x11
- --socket=wayland
- --filesystem=host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need full host?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File open/save dialogue seems to support the filechooser portal

com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.yaml Show resolved Hide resolved
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
@saturneric saturneric force-pushed the gpgfrontend branch 3 times, most recently from 858e4dd to 1f34744 Compare October 15, 2023 11:38
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
@saturneric saturneric force-pushed the gpgfrontend branch 3 times, most recently from 677469c to 88e6f48 Compare October 15, 2023 11:44
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
@saturneric saturneric force-pushed the gpgfrontend branch 2 times, most recently from 3e96ff6 to 82c1294 Compare October 15, 2023 12:04
com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
@saturneric saturneric force-pushed the gpgfrontend branch 3 times, most recently from fb86dd0 to c04ff07 Compare October 15, 2023 12:17
- --device=dri
- --share=network
- --filesystem=home
- --filesystem=/run/user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for gpg agent socket? Then what you want is --socket=gpg-agent which gives access to gpgconf --list-dirs agent-socket

com.bktus.gpgfrontend.yaml Outdated Show resolved Hide resolved
@saturneric saturneric force-pushed the gpgfrontend branch 5 times, most recently from 4340c26 to 84d8da8 Compare October 15, 2023 12:27
@bbhtt
Copy link
Contributor

bbhtt commented Oct 15, 2023

bot, build com.bktus.gpgfrontend

@flathubbot
Copy link

Queued test build for com.bktus.gpgfrontend.

buildsystem: simple
build-commands:
- ./bootstrap.sh --prefix=${FLATPAK_DEST} --with-libraries=date_time,system
- ./b2 variant=release link=static runtime-link=shared cxxflags="$CXXFLAGS" linkflags="$LDFLAGS" -j $(nproc) install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ./b2 variant=release link=static runtime-link=shared cxxflags="$CXXFLAGS" linkflags="$LDFLAGS" -j $(nproc) install
- ./b2 variant=release link=static runtime-link=shared cxxflags="$CXXFLAGS" linkflags="$LDFLAGS" -j $FLATPAK_BUILDER_N_JOBS install

@flathubbot
Copy link

Started test build 73849

@flathubbot
Copy link

Build 73849 failed

@hfiguiere
Copy link
Contributor

ninja: error: '/usr/lib/x86_64-linux-gnu/libicui18n.so', needed by 'src/core/libgpgfrontend_core.so', missing and no known rule to make it

@saturneric
Copy link
Author

saturneric commented Oct 15, 2023

ninja: error: '/usr/lib/x86_64-linux-gnu/libicui18n.so', needed by 'src/core/libgpgfrontend_core.so', missing and no known rule to make it

Solved it. Hard coded icu library links were found at project configuration files.

@bbhtt
Copy link
Contributor

bbhtt commented Oct 15, 2023

bot, build com.bktus.gpgfrontend

@flathubbot
Copy link

Queued test build for com.bktus.gpgfrontend.

@flathubbot
Copy link

Started test build 73885

@flathubbot
Copy link

Build 73885 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/56533/com.bktus.gpgfrontend.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/com.bktus.gpgfrontend

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants