RuneLite #489

rushsteve1 · 2018-07-14T21:35:04Z

RuneLite OSRS client.
I was having some trouble setting up some persistent files. RuneLite automatically puts 2 files and a folder in the user's home folder which I wanted to avoid doing, but I cannot figure out how to make them persistent in the Flatpak. Some help on this would be greatly appreciated.

RuneLite OSRS client. Persistent cache still needs to be done.

TingPing · 2018-07-14T22:17:20Z

RuneLite automatically puts 2 files and a folder in the user's home folder which I wanted to avoid doing, but I cannot figure out how to make them persistent in the Flatpak. Some help on this would be greatly appreciated.

You have to resort to hacks if it makes single files in $HOME like a wrapper script that sets $HOME to a private directory in $XDG_CONFIG_HOME assuming it respects that env var.

TingPing · 2018-07-14T22:19:02Z

net.runelite.RuneLite.desktop

@@ -0,0 +1,9 @@
+[Desktop Entry]


You have data files but never install them.

Yep, same thing with the appdata file.

This was fixed.

AsciiWolf · 2018-07-15T10:43:10Z

net.runelite.RuneLite.json

+                    "type": "script",
+                    "dest-filename": "runelite",
+                    "commands": [
+                        "ls -R /app | grep jagex",


What is this good for? Seems to be just a check if the directory exist.

Oh. I forgot to remove that.

AsciiWolf · 2018-07-15T10:46:32Z

net.runelite.RuneLite.json

+        "--socket=wayland",
+        "--socket=pulseaudio",
+        "--env=JAVA_HOME=/app/jre",
+        "--persist=~"


I am not sure if this is actually used. The RuneLite updater seems to be downloading all the game files every time.

(You can make multiple --persist options, for example --persist=.foo, --persist=.bar will make the ~/.foo and ~/.bar files/directories persistent.)

AsciiWolf · 2018-07-15T12:42:02Z

diff --git a/net.runelite.RuneLite.desktop b/net.runelite.RuneLite.desktop
index 89d5cc5..511562c 100644
--- a/net.runelite.RuneLite.desktop
+++ b/net.runelite.RuneLite.desktop
@@ -6,4 +6,4 @@ Comment=RuneLite is a free, open-source and super fast client for Old School Run
 Keywords=games;runescape;osrs;
 Exec=runelite
 Icon=net.runelite.RuneLite
-Categories=Game;MMO;
+Categories=Game;RolePlaying;
diff --git a/net.runelite.RuneLite.json b/net.runelite.RuneLite.json
index 089da41..bb48bd7 100644
--- a/net.runelite.RuneLite.json
+++ b/net.runelite.RuneLite.json
@@ -30,14 +30,16 @@
             "buildsystem": "simple",
             "build-commands": [
                 "install -D runelite /app/bin/runelite",
-                "install -D RuneLite.jar /app/share/RuneLite.jar"
+                "install -D RuneLite.jar /app/share/RuneLite.jar",
+                "install -Dm644 net.runelite.RuneLite.png /app/share/icons/hicolor/128x128/apps/net.runelite.RuneLite.png",
+                "install -Dm644 net.runelite.RuneLite.desktop /app/share/applications/net.runelite.RuneLite.desktop",
+                "install -Dm644 net.runelite.RuneLite.appdata.xml /app/share/appdata/net.runelite.RuneLite.appdata.xml"
             ],
             "sources": [
                 {
                     "type": "script",
                     "dest-filename": "runelite",
                     "commands": [
-                        "ls -R /app | grep jagex",
                         "exec $JAVA_HOME/bin/java -jar /app/share/RuneLite.jar"
                     ]
                 },
@@ -45,6 +47,18 @@
                     "type": "file",
                     "url": "https://github.com/runelite/launcher/releases/download/1.6.0/RuneLite.jar",
                     "sha256": "fdcfdd51b033815c4f45025c315175b8a20cc080b65a8b76aee5519b39e85d60"
+                },
+                {
+                    "type": "file",
+                    "path": "net.runelite.RuneLite.png"
+                },
+                {
+                    "type": "file",
+                    "path": "net.runelite.RuneLite.desktop"
+                },
+                {
+                    "type": "file",
+                    "path": "net.runelite.RuneLite.appdata.xml"
                 }
             ]
         }

Here's a fix to make the desktop/appdata files working (and also to remove the unnecessary check).

Persistent RuneLite files are still an issue; if they have always the same name, you can use --persist, but if their name is changing, you have to use some hack like TingPing suggested.

AsciiWolf · 2018-07-15T12:44:36Z

net.runelite.RuneLite.appdata.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>


Also, please add OARS metadata to the appdata file.

rushsteve1 · 2018-07-16T12:44:30Z

@AsciiWolf Thank you for your patch! And the files do not change name as far as I can tell, but when I tried using --persist on them it generated folders of the same name instead and persisted those.

AsciiWolf · 2018-07-16T12:51:38Z

@rushsteve1 Ah, weird, I thought that --persist supports files as well. :-/

AsciiWolf · 2018-07-16T12:52:43Z

net.runelite.RuneLite.desktop

+Keywords=games;runescape;osrs;
+Exec=runelite
+Icon=net.runelite.RuneLite
+Categories=Game;MMO;


Should be Game;RolePlaying;. It is fixed in my patch.

- Made another attempt at persistence. Doesn't seem to work. - Added OARS.

rushsteve1 · 2018-07-16T13:32:24Z

Ok last commit merged @AsciiWolf's patch and added OARS data. I also tried setting a HOME in the launcher script to a folder and then persisting that folder but it didn't seem to work so any more suggestions would be greatly appreciated.
Because to be honest those files cluttering my home folder were what prompted me to do this 🙃

AsciiWolf · 2018-07-16T13:45:07Z

net.runelite.RuneLite.appdata.xml

+        <release version="1.6.0" date="2018-7-7"></release>
+    </releases>
+    <update_contact>rushsteve1_at_teknik.io</update_contact>
+


Unnecessary empty line. :-)

AsciiWolf · 2018-07-16T13:48:08Z

@rushsteve1: It's a pity that the persist workaround didn't work. :-/ Maybe @alexlarsson will know more about this?

Got it to at least persist the downloaded files

rushsteve1 · 2018-07-16T19:29:31Z

I figured out how to persist the downloaded data and the jagexcache which are both folders. The downloaded data was the big thing.
To be honest I have no idea what the two files I cannot persist actually do and they don't seem to affect anything when removed.

nedrichards · 2018-07-17T14:58:25Z

bot, build net.runelite.RuneLite

AsciiWolf · 2018-07-17T18:58:34Z

I can confirm that the issue with persistent files is now fixed. Game is fully playable, however, there are still some minor issues:

Button to recover account password does not work.
UI is a little glitchy (does not prevent the actual gameplay).
Tray icon seems to be empty.

rushsteve1 · 2018-07-17T20:18:12Z

In response to @AsciiWolf's concerns:

The button to recover account password is either an issue opening the browser or with the game itself. Can you create a new account from the game?
Do you mean the right sidebar UI? If so then this is a known RuneLite bug and happens on all platforms.
I might need to rename the icon for it to work, I'll check on that.

AsciiWolf · 2018-07-17T20:24:39Z

@rushsteve1:

I didn't try to create a new account from the game and I don't have any e-mail address available that I can use to test it.
Yes, the right sidebar UI.
I found out that the icon is displayed, but placed on the left side of my desktop. Weird, maybe some bug in the TopIcons Plus GNOME Shell extension that I use.

AsciiWolf · 2018-07-19T10:54:18Z

@TingPing It looks like that all the issues (except the password recover one and the other two that are not related to the Flatpak) were fixed.

rushsteve1 · 2018-07-21T12:43:11Z

The Password recover issue is the same as when you click "Create Account" it wont open the browser. I have no idea what would cause that.

AsciiWolf · 2018-07-21T16:22:34Z

@rushsteve1 I tried to debug this issue, but no luck. I have however found some other errors, but none of them seems to be fatal.

After RuneLite is started, this appears on stdout:

libGL error: MESA-LOADER: failed to retrieve device information
libGL error: unable to load driver: amdgpu_dri.so
libGL error: driver pointer missing
libGL error: failed to load driver: amdgpu
libGL error: failed to open drm device: No such file or directory
libGL error: failed to load driver: radeonsi

There are also some javax.net.ssl.SSLHandshakeException warnings in the game log, but they don't seem to affect anything.

rushsteve1 · 2018-07-21T22:59:46Z

I assume that the driver issues are attempts at loading some form of hardware acceleration. While that would be nice to have I know nothing about Flatpak and drivers, and to be blunt this is a browser game from 2007. The performance requirements are minimal.

The javax.net.ssl.SSLHandshakeException are probably just dropped packets or something, I am not terribly worried about it.

AsciiWolf · 2018-07-22T14:12:39Z

@rushsteve1 I don't see any problem in the json file. But I found out that RuneLite devs itself recommend disabling 3D acceleration in some cases and RuneLite probably works fine without 3D acceleration.

AsciiWolf · 2018-07-24T09:56:48Z

Anyway, besides the browser issue and the glitched UI that is an upstream issue, it seems to work fine so this PR can probably be merged. ;-)

rushsteve1 · 2018-07-29T18:36:22Z

@TingPing @AsciiWolf Is there anything else that needs to be done before this is merged?

nedrichards · 2018-07-30T11:20:35Z

Repository has been created: https://github.com/flathub/net.runelite.RuneLite

RuneLite

bf9e6fc

RuneLite OSRS client. Persistent cache still needs to be done.

TingPing requested changes Jul 14, 2018

View reviewed changes

AsciiWolf reviewed Jul 15, 2018

View reviewed changes

AsciiWolf reviewed Jul 16, 2018

View reviewed changes

Merged AsciiWolf's patch and some

86c5b66

- Made another attempt at persistence. Doesn't seem to work. - Added OARS.

AsciiWolf reviewed Jul 16, 2018

View reviewed changes

Improved Persist

a4334bc

Got it to at least persist the downloaded files

nedrichards closed this Jul 30, 2018

bbhtt mentioned this pull request Jan 12, 2024

Security of verified apps #4855

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RuneLite #489

RuneLite #489

rushsteve1 commented Jul 14, 2018 •

edited by nedrichards

Loading

TingPing commented Jul 14, 2018

TingPing Jul 14, 2018

AsciiWolf Jul 15, 2018

rushsteve1 Jul 16, 2018

AsciiWolf Jul 15, 2018

rushsteve1 Jul 16, 2018

AsciiWolf Jul 15, 2018

AsciiWolf Jul 15, 2018

AsciiWolf commented Jul 15, 2018

AsciiWolf Jul 15, 2018

rushsteve1 commented Jul 16, 2018

AsciiWolf commented Jul 16, 2018

AsciiWolf Jul 16, 2018

rushsteve1 commented Jul 16, 2018

AsciiWolf Jul 16, 2018

AsciiWolf commented Jul 16, 2018

rushsteve1 commented Jul 16, 2018

nedrichards commented Jul 17, 2018

AsciiWolf commented Jul 17, 2018

rushsteve1 commented Jul 17, 2018

AsciiWolf commented Jul 17, 2018

AsciiWolf commented Jul 19, 2018 •

edited

Loading

rushsteve1 commented Jul 21, 2018

AsciiWolf commented Jul 21, 2018

rushsteve1 commented Jul 21, 2018

AsciiWolf commented Jul 22, 2018

AsciiWolf commented Jul 24, 2018

rushsteve1 commented Jul 29, 2018

nedrichards commented Jul 30, 2018

RuneLite #489

RuneLite #489

Conversation

rushsteve1 commented Jul 14, 2018 • edited by nedrichards Loading

TingPing commented Jul 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AsciiWolf commented Jul 15, 2018

Choose a reason for hiding this comment

rushsteve1 commented Jul 16, 2018

AsciiWolf commented Jul 16, 2018

Choose a reason for hiding this comment

rushsteve1 commented Jul 16, 2018

Choose a reason for hiding this comment

AsciiWolf commented Jul 16, 2018

rushsteve1 commented Jul 16, 2018

nedrichards commented Jul 17, 2018

AsciiWolf commented Jul 17, 2018

rushsteve1 commented Jul 17, 2018

AsciiWolf commented Jul 17, 2018

AsciiWolf commented Jul 19, 2018 • edited Loading

rushsteve1 commented Jul 21, 2018

AsciiWolf commented Jul 21, 2018

rushsteve1 commented Jul 21, 2018

AsciiWolf commented Jul 22, 2018

AsciiWolf commented Jul 24, 2018

rushsteve1 commented Jul 29, 2018

nedrichards commented Jul 30, 2018

rushsteve1 commented Jul 14, 2018 •

edited by nedrichards

Loading

AsciiWolf commented Jul 19, 2018 •

edited

Loading